Disable page ID vs PageState CHECK in release builds for now.

Disable page ID vs PageState CHECK in release builds for now.

There are some cases in UseSubframeNavigationEntries where a
FrameNavigationEntry ends up with an empty PageState, leading
to this crash.  Until it is diagnosed, downgrade it to a
DCHECK.  The only functional regression should be a loss of
things like scroll position and form data when using modes
like --isolate-extensions.

BUG=568703
TEST=No more RenderFrameImpl::NavigateInternal crashes.

Committed: https://crrev.com/f4c12df45838eae34c2646526a76a91365908aeb
Cr-Commit-Position: refs/heads/master@{#407525}

[Charlie Reis, 2016-07-25 04:32:22]

The CQ bit was checked by creis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 04:32:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 05:21:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 05:21:41]

Dry run: This issue passed the CQ dry run.

[Charlie Reis, 2016-07-25 17:14:04]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2016-07-25 17:14:05]

Nasko, what do you think about this as a stopgap while we keep looking into the
problems with bad PageState?

[nasko, 2016-07-25 18:21:27]

LGTM

[Charlie Reis, 2016-07-25 18:28:15]

The CQ bit was checked by creis@chromium.org

[commit-bot: I haz the power, 2016-07-25 18:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 18:35:03]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 18:37:20]

Description was changed from

==========
Disable page ID vs PageState CHECK in release builds for now.

There are some cases in UseSubframeNavigationEntries where a
FrameNavigationEntry ends up with an empty PageState, leading
to this crash.  Until it is diagnosed, downgrade it to a
DCHECK.  The only functional regression should be a loss of
things like scroll position and form data when using modes
like --isolate-extensions.

BUG=568703
TEST=No more RenderFrameImpl::NavigateInternal crashes.
==========

to

==========
Disable page ID vs PageState CHECK in release builds for now.

There are some cases in UseSubframeNavigationEntries where a
FrameNavigationEntry ends up with an empty PageState, leading
to this crash.  Until it is diagnosed, downgrade it to a
DCHECK.  The only functional regression should be a loss of
things like scroll position and form data when using modes
like --isolate-extensions.

BUG=568703
TEST=No more RenderFrameImpl::NavigateInternal crashes.

Committed: https://crrev.com/f4c12df45838eae34c2646526a76a91365908aeb
Cr-Commit-Position: refs/heads/master@{#407525}
==========

[commit-bot: I haz the power, 2016-07-25 18:37:21]

Patchset 1 (id:??) landed as
https://crrev.com/f4c12df45838eae34c2646526a76a91365908aeb
Cr-Commit-Position: refs/heads/master@{#407525}