Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2174243002: Disable page ID vs PageState CHECK in release builds for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index d2030c35e017a83ed17e6526dbb2907d173b90c1..b676e3e19e1dffbdcb8e66c5b2e6eaf0495cccaa 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -5615,7 +5615,11 @@ void RenderFrameImpl::NavigateInternal(
}
// A session history navigation should have been accompanied by state.
- CHECK_EQ(request_params.page_id, -1);
+ // TODO(creis): This is known to be failing in UseSubframeNavigationEntries
+ // in https://crbug.com/568703, when the PageState on a FrameNavigationEntry
+ // is unexpectedly empty. Until the cause is found, keep this as a DCHECK
+ // and load the URL without PageState.
+ DCHECK_EQ(request_params.page_id, -1);
should_load_request = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698