Minor changes to GrFontCache system

Minor changes to GrFontCache system.

The main change is parameterizing the GrAtlasMgr so it can have a different sized backing texture and a different number of plots. This is in support of the saveLayer cache which has a smaller backing texture and only one plot.

Committed: http://code.google.com/p/skia/source/detail?r=14011

[robertphillips, 2014-04-01 15:07:16]

added Brian for API review

[bsalomon, 2014-04-01 15:19:00]

On 2014/04/01 15:07:16, robertphillips wrote:
> added Brian for API review

api lgtm

[jvanverth1, 2014-04-01 15:32:43]

LGTM  + comments.

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrAtlas.cpp#newcode79
src/gpu/GrAtlas.cpp:79: int backingTextureWidth, int backingTextureHeight,
One thing that might be worth considering is whether it'd be better to use an
SkISIze here (and change fBackingTexture{Width|Height} to fBackingTextureSize).
On one hand, it would reduce the need to push the later arguments on the stack
for Android (the first four or five end up in registers). On the other, you'd
have to create an SkISize in GrTextStrike to pass in.

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp#new...
src/gpu/GrTextStrike.cpp:25: #define GR_ATLAS_TEXTURE_WIDTH  (GR_PLOT_WIDTH *
GR_ATLAS_WIDTH)
This won't compile. I'm not sure we need this section anyway.

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp#new...
src/gpu/GrTextStrike.cpp:33: #define GR_ATLAS_WIDTH  256
Since you're changing stuff, this should be GR_PLOT_WIDTH and GR_PLOT_HEIGHT.

[robertphillips, 2014-04-01 15:45:54]

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrAtlas.cpp
File src/gpu/GrAtlas.cpp (right):

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrAtlas.cpp#newcode79
src/gpu/GrAtlas.cpp:79: int backingTextureWidth, int backingTextureHeight,
On 2014/04/01 15:32:43, JimVV wrote:
> One thing that might be worth considering is whether it'd be better to use an
> SkISIze here (and change fBackingTexture{Width|Height} to
fBackingTextureSize).
> On one hand, it would reduce the need to push the later arguments on the stack
> for Android (the first four or five end up in registers). On the other, you'd
> have to create an SkISize in GrTextStrike to pass in. 

Done.

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp
File src/gpu/GrTextStrike.cpp (right):

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp#new...
src/gpu/GrTextStrike.cpp:25: #define GR_ATLAS_TEXTURE_WIDTH  (GR_PLOT_WIDTH *
GR_ATLAS_WIDTH)
On 2014/04/01 15:32:43, JimVV wrote:
> This won't compile. I'm not sure we need this section anyway.

Done.

https://codereview.chromium.org/217423014/diff/1/src/gpu/GrTextStrike.cpp#new...
src/gpu/GrTextStrike.cpp:33: #define GR_ATLAS_WIDTH  256
On 2014/04/01 15:32:43, JimVV wrote:
> Since you're changing stuff, this should be GR_PLOT_WIDTH and GR_PLOT_HEIGHT.

Done.

[robertphillips, 2014-04-01 15:46:03]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-04-01 15:46:08]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/robertphillips@google.com/217423014/2...

[commit-bot: I haz the power, 2014-04-01 16:25:18]

Change committed as 14011