Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2174213002: Specify GTEST_LANG_CXX11 to 1 explicitly rather than let gtest detect it (Closed)

Created:
4 years, 5 months ago by tzik
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Specify GTEST_LANG_CXX11 to 1 explicitly rather than let gtest detect it gtest uses __cplusplus value to detect whether C++11 features are available. However, some of Windows bots has smaller value that C++11 spec defines. That makes gtest fallback to pre-C++11 mode unnecessarily. This CL adds GTEST_LANG_CXX11 to force gtest use C++11 mode. BUG=630299 Committed: https://crrev.com/025e90e6a024e92bc35af561b605dcd09719766e Cr-Commit-Position: refs/heads/master@{#407408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/secondary/testing/gtest/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M testing/gtest.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
tzik
PTAL
4 years, 4 months ago (2016-07-25 00:43:40 UTC) #8
Dirk Pranke
lgtm
4 years, 4 months ago (2016-07-25 02:33:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2174213002/1
4 years, 4 months ago (2016-07-25 03:24:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-07-25 03:28:33 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-07-25 03:30:22 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/025e90e6a024e92bc35af561b605dcd09719766e
Cr-Commit-Position: refs/heads/master@{#407408}

Powered by Google App Engine
This is Rietveld 408576698