Issue 2174193002: exo: Implement custom fullscreening for ShellSurfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2174193002: exo: Implement custom fullscreening for ShellSurfaces. (Closed)

Created:
4 years, 5 months ago by reveman

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

exo: Implement custom fullscreening for ShellSurfaces. This allows us to restore to maximized mode when fullscreen is toggled by the user pressing F4. BUG=630696 ,b/29817350 TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen Review-Url: https://codereview.chromium.org/2177623002 Cr-Commit-Position: refs/heads/master@{#407248} (cherry picked from commit 25f638ab8c4adbf3470b2e0e07183919f60bc3f9) Committed: https://chromium.googlesource.com/chromium/src/+/f44deef2faa1b672f672a504e470d9d5eaac1112

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+76 lines, -0 lines)			Patch
	M	components/exo/shell_surface.cc	View		4 chunks	+39 lines, -0 lines	0 comments	Download
	M	components/exo/shell_surface_unittest.cc	View		2 chunks	+37 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

reveman

4 years, 5 months ago (2016-07-24 02:08:29 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f44deef2faa1b672f672a504e470d9d5eaac1112.