exo: Implement custom fullscreening for ShellSurfaces.

exo: Implement custom fullscreening for ShellSurfaces.

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG=630696
,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen

Committed: https://crrev.com/25f638ab8c4adbf3470b2e0e07183919f60bc3f9
Cr-Commit-Position: refs/heads/master@{#407248}

[reveman, 2016-07-22 18:50:21]

reveman@chromium.org changed reviewers:
+ oshima@chromium.org

[reveman, 2016-07-22 19:48:27]

The CQ bit was checked by reveman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 19:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2016-07-22 19:50:56]

lgtm

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:115: // Overridden from
ash::wm::WindowStateDelegate:
nit: // ash::wm::WindowStateDelegate:

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:124: // Overridden from views::WidgetObserver:
ditto

[reveman, 2016-07-22 19:59:17]

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
File components/exo/shell_surface.cc (right):

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:115: // Overridden from
ash::wm::WindowStateDelegate:
On 2016/07/22 at 19:50:56, oshima wrote:
> nit: // ash::wm::WindowStateDelegate:

as discussed, I'll change the style for all exo/ code in a follow up.

https://codereview.chromium.org/2177623002/diff/1/components/exo/shell_surfac...
components/exo/shell_surface.cc:124: // Overridden from views::WidgetObserver:
On 2016/07/22 at 19:50:56, oshima wrote:
> ditto

ditto

[reveman, 2016-07-22 19:59:23]

The CQ bit was unchecked by reveman@chromium.org

[reveman, 2016-07-22 19:59:25]

The CQ bit was checked by reveman@chromium.org

[commit-bot: I haz the power, 2016-07-22 19:59:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 20:27:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 20:32:14]

Description was changed from

==========
exo: Implement custom fullscreening for ShellSurfaces.

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG=630696,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen
==========

to

==========
exo: Implement custom fullscreening for ShellSurfaces.

This allows us to restore to maximized mode when fullscreen
is toggled by the user pressing F4.

BUG=630696,b/29817350
TEST=exo_unittests --gtest_filter=ShellSurfaceTest.ToggleFullscreen

Committed: https://crrev.com/25f638ab8c4adbf3470b2e0e07183919f60bc3f9
Cr-Commit-Position: refs/heads/master@{#407248}
==========

[commit-bot: I haz the power, 2016-07-22 20:32:15]

Patchset 1 (id:??) landed as
https://crrev.com/25f638ab8c4adbf3470b2e0e07183919f60bc3f9
Cr-Commit-Position: refs/heads/master@{#407248}