[md] Fixes tooltips on Linux that should not have changed

[md] Fixes tooltips regression on Linux that should not have changed

I have tried making rounded corners work on Linux but so far haven't
succeeded. I can make the non-opaque background work using
Widget::SetOpacity and ui::Layer::SetFillsBoundsOpaquely but the native
widget on Linux still paints around the rounded corners.
Widget::SetShape doesn't use antialiasing so using that to achieve
rounded corners appears crude.
There is some work to make transparency work better on Linux
https://codereview.chromium.org/2124633002 so I haven't pursued this
further.

BUG=630556
Committed: https://crrev.com/6ea8ec306bee7352409e5c0d76547fc9f802d640
Cr-Commit-Position: refs/heads/master@{#407350}

[varkha, 2016-07-22 21:28:00]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 21:28:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-22 21:29:11]

The CQ bit was unchecked by varkha@chromium.org

[varkha, 2016-07-22 21:29:26]

Patchset #1 (id:1) has been deleted

[varkha, 2016-07-22 21:31:29]

varkha@chromium.org changed reviewers:
+ sadrul@chromium.org

[varkha, 2016-07-22 21:31:29]

sadrul@, can you please take a look? Is there something better to get rounded
corners work on Linux?

[sadrul, 2016-07-23 01:08:05]

https://codereview.chromium.org/2174033002/diff/20001/ui/views/corewm/tooltip...
File ui/views/corewm/tooltip_aura.cc (right):

https://codereview.chromium.org/2174033002/diff/20001/ui/views/corewm/tooltip...
ui/views/corewm/tooltip_aura.cc:50: }
I think we shouldn't set the opacity to translucent either?

May be we can have a function CanUseTranslucentTooltipWidget():

  bool CanUseTranslucentTooltipWidget() {
#if linux desktop
    return false;
#else
    return ui::MaterialDesignController::IsModeMaterial();
#endif
  }

and use that here and below instead? I feel the code would be cleaner that way.

[varkha, 2016-07-23 01:21:58]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-23 01:22:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-07-23 01:22:18]

Thanks, indeed looks simpler.

https://codereview.chromium.org/2174033002/diff/20001/ui/views/corewm/tooltip...
File ui/views/corewm/tooltip_aura.cc (right):

https://codereview.chromium.org/2174033002/diff/20001/ui/views/corewm/tooltip...
ui/views/corewm/tooltip_aura.cc:50: }
On 2016/07/23 01:08:05, sadrul wrote:
> I think we shouldn't set the opacity to translucent either?
> 
> May be we can have a function CanUseTranslucentTooltipWidget():
> 
>   bool CanUseTranslucentTooltipWidget() {
> #if linux desktop
>     return false;
> #else
>     return ui::MaterialDesignController::IsModeMaterial();
> #endif
>   }
> 
> and use that here and below instead? I feel the code would be cleaner that
way.

Done.

[sadrul, 2016-07-23 01:24:24]

lgtm

[commit-bot: I haz the power, 2016-07-23 01:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 01:27:55]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2016-07-23 01:29:59]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2016-07-23 01:30:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 02:00:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-23 02:00:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[varkha, 2016-07-23 03:57:14]

The CQ bit was checked by varkha@chromium.org

[commit-bot: I haz the power, 2016-07-23 03:57:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-23 04:31:45]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-07-23 04:32:53]

Description was changed from

==========
[md] Fixes tooltips regression on Linux that should not have changed

I have tried making rounded corners work on Linux but so far haven't
succeeded. I can make the non-opaque background work using
Widget::SetOpacity and ui::Layer::SetFillsBoundsOpaquely but the native
widget on Linux still paints around the rounded corners.
Widget::SetShape doesn't use antialiasing so using that to achieve
rounded corners appears crude.
There is some work to make transparency work better on Linux
https://codereview.chromium.org/2124633002 so I haven't pursued this
further.

BUG=630556
==========

to

==========
[md] Fixes tooltips regression on Linux that should not have changed

I have tried making rounded corners work on Linux but so far haven't
succeeded. I can make the non-opaque background work using
Widget::SetOpacity and ui::Layer::SetFillsBoundsOpaquely but the native
widget on Linux still paints around the rounded corners.
Widget::SetShape doesn't use antialiasing so using that to achieve
rounded corners appears crude.
There is some work to make transparency work better on Linux
https://codereview.chromium.org/2124633002 so I haven't pursued this
further.

BUG=630556

Committed: https://crrev.com/6ea8ec306bee7352409e5c0d76547fc9f802d640
Cr-Commit-Position: refs/heads/master@{#407350}
==========

[commit-bot: I haz the power, 2016-07-23 04:32:54]

Patchset 2 (id:??) landed as
https://crrev.com/6ea8ec306bee7352409e5c0d76547fc9f802d640
Cr-Commit-Position: refs/heads/master@{#407350}