Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2124633002:
Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS (Closed)
|
Created:
4 years, 5 months ago by Julien Isorce Samsung Modified:
4 years, 5 months ago CC:
chromium-reviews, darin-cc_chromium.org, derat+watch_chromium.org, piman+watch_chromium.org, ppc1_chromium.org, sadrul, tfarina, yusukes+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS
This is for better polish in the UI but it fixes a drag
image issue on Linux crbug.com/593256 .
Also add a kGpuDriverBugListJson entry to automatically
disable transparent visuals on all drivers (especially
the proprietary NVIDIA driver) except for opensource
drivers (i.e. Mesa based drivers).
BUG=369209
R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42
Committed: https://crrev.com/102b4b07240352221cf4256ff84bf71e2f9189a2
Cr-Original-Commit-Position: refs/heads/master@{#406505}
Cr-Commit-Position: refs/heads/master@{#407137}
Patch Set 1 #Patch Set 2 : Rebase and increment version #Patch Set 3 : Add missing USE_X11 guard to fix the build #Patch Set 4 : Rebase and enable alpha in WindowsApiAlphaEnabledHasPermissions on Linux #Patch Set 5 : check for _CHROMIUM_INSIDE_XVFB var to relax unit test #
Total comments: 8
Patch Set 6 : Rebase, use enable instead of disable, restrict to mesa drivers only #Patch Set 7 : Rebase and check for depth in WindowsApiAlphaEnabledHasPermissions test #Patch Set 8 : Rebase #
Total comments: 5
Patch Set 9 : Rebase #
Total comments: 6
Patch Set 10 : Rebase and addressed remarks from tapted #
Total comments: 1
Patch Set 11 : Rebase and add 2 browser tests #Patch Set 12 : indent #Patch Set 13 : indent #Patch Set 14 : Rebase #Patch Set 15 : Simplify test #Patch Set 16 : Really run the 2 new tests on Linux only #Patch Set 17 : Rebase #Patch Set 18 : Rebase and do not run tests on Android #Patch Set 19 : Just make sure the new gpu driver workaround exist in second test instead of using fake values #
Messages
Total messages: 146 (85 generated)
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org,piman@chromium.org,zmo@chromium.org ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org,piman@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org,piman@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org,piman@chromium.org,sadrul@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
j.isorce@samsung.com changed reviewers: + sadrul@chromium.org
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org,piman@chromium.org,sadrul@chromium.org,zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org, piman@chromium.org, sadrul@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/07/05 14:49:52, commit-bot: I haz the power wrote: > Dry run: This issue passed the CQ dry run. Hi, please have a look. Thx.
kbr@chromium.org changed reviewers: + cwallez@chromium.org
cwallez@: could you review this change?
On 2016/07/06 at 21:49:35, kbr wrote: > cwallez@: could you review this change? LGTM with a couple nits. What's the rational for enabling transparent visuals on compositing window managers, is it to potentially avoid a blit (at the expense of a small memory usage increase)?
On 2016/07/06 22:08:29, Corentin Wallez wrote: > On 2016/07/06 at 21:49:35, kbr wrote: > > cwallez@: could you review this change? > > LGTM with a couple nits. Thanks for your review. > What's the rational for enabling transparent visuals on compositing window > managers, is it to potentially avoid a blit (at the expense of a small memory > usage increase)? Per http://crbug.com/369209 it looks like it's mainly a desire for better polish in the UI. Didn't see your nits; did you publish them?
https://codereview.chromium.org/2124633002/diff/80001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2124633002/diff/80001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:1871: "disable_transparent_visuals" This is a large behavioral change for all Chrome users on Linux except those on NVIDIA's drivers. I think it's too great a risk to take. Instead, disable_transparent_visuals should be the default, and it should be selectively enabled on drivers known to work. https://codereview.chromium.org/2124633002/diff/80001/ui/views/widget/widget_... File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/2124633002/diff/80001/ui/views/widget/widget_... ui/views/widget/widget_unittest.cc:3749: bool has_compositing_manager = env->HasVar("_CHROMIUM_INSIDE_XVFB"); This is a hack. Is there no better way to determine whether to try transparent visuals?
Couple nits in addition of Ken's comments. https://codereview.chromium.org/2124633002/diff/80001/content/browser/browser... File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2124633002/diff/80001/content/browser/browser... content/browser/browser_main_loop.cc:762: // PreCreateThreads is called before CreateStartupTasks which one starts the nit: which one -> which https://codereview.chromium.org/2124633002/diff/80001/ui/base/x/x11_util.cc File ui/base/x/x11_util.cc (right): https://codereview.chromium.org/2124633002/diff/80001/ui/base/x/x11_util.cc#n... ui/base/x/x11_util.cc:1415: void ChooseVisualForWindow(bool disable_transparent_visuals, nit: making this enable_transparent_visuals would get rid of two negations in the CL.
On 2016/07/06 22:25:58, Ken Russell wrote: > On 2016/07/06 22:08:29, Corentin Wallez wrote: > > What's the rational for enabling transparent visuals on compositing window > > managers, is it to potentially avoid a blit (at the expense of a small memory > > usage increase)? > > Per http://crbug.com/369209 it looks like it's mainly a desire for better polish > in the UI. Thx for the reviews Corentin and Ken. That is a very good question, to be honest I did it for the reason that Ken mentioned. But you are right it can avoid a blit in some situation though even with depth 24 it could still be 32 bpp so it won't save anything in that case. But looking at the bug comments I can see that crbug.com/593256 (which is merged into crbug.com/550999 which one is merged into http://crbug.com/369209) describes a real bug and this CL fixes it :) Just open an incognito window, select text and drag it. (for ease you can even try without this CL to test it, just run the steps with and without --enable-transparent-visuals) As per your comments thx and I agree all of them. About "_CHROMIUM_INSIDE_XVFB" I could not find a better solution, well there is switches::kTestLauncherBotMode but it is different.
https://codereview.chromium.org/2124633002/diff/80001/content/browser/browser... File content/browser/browser_main_loop.cc (right): https://codereview.chromium.org/2124633002/diff/80001/content/browser/browser... content/browser/browser_main_loop.cc:762: // PreCreateThreads is called before CreateStartupTasks which one starts the On 2016/07/07 00:09:23, Corentin Wallez wrote: > nit: which one -> which Done. https://codereview.chromium.org/2124633002/diff/80001/gpu/config/gpu_driver_b... File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/2124633002/diff/80001/gpu/config/gpu_driver_b... gpu/config/gpu_driver_bug_list_json.cc:1871: "disable_transparent_visuals" On 2016/07/06 22:32:17, Ken Russell wrote: > This is a large behavioral change for all Chrome users on Linux except those on > NVIDIA's drivers. I think it's too great a risk to take. Instead, > disable_transparent_visuals should be the default, and it should be selectively > enabled on drivers known to work. Done. Exception is for mesa drivers only. I tested on intel and "nouveau" drivers but I have not tested the opensource driver for amd hardware, but since it is mesa, it should be the same code/mechanism underneath for the visual selection. Also initially this issue was only reported for NVIDIA proprietary driver. https://codereview.chromium.org/2124633002/diff/80001/ui/base/x/x11_util.cc File ui/base/x/x11_util.cc (right): https://codereview.chromium.org/2124633002/diff/80001/ui/base/x/x11_util.cc#n... ui/base/x/x11_util.cc:1415: void ChooseVisualForWindow(bool disable_transparent_visuals, On 2016/07/07 00:09:23, Corentin Wallez wrote: > nit: making this enable_transparent_visuals would get rid of two negations in > the CL. Done https://codereview.chromium.org/2124633002/diff/80001/ui/views/widget/widget_... File ui/views/widget/widget_unittest.cc (right): https://codereview.chromium.org/2124633002/diff/80001/ui/views/widget/widget_... ui/views/widget/widget_unittest.cc:3749: bool has_compositing_manager = env->HasVar("_CHROMIUM_INSIDE_XVFB"); On 2016/07/06 22:32:17, Ken Russell wrote: > This is a hack. Is there no better way to determine whether to try transparent > visuals? The idea here is to only do EXPECT_EQ(depth, 32); if the test is ran under src/testing/xvfb.py because now this script also starts a compositing manager named xcompmgr. And I have not found a better to check that the test is ran within this script. In any other configuration the test should not assert there, for example it will fails with nvidia proprietary drivers if the driver contains that bug.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM, but please consider changing the sense of the driver bug workaround. Thanks. https://codereview.chromium.org/2124633002/diff/130011/extensions/browser/api... File extensions/browser/api/app_window/app_window_apitest.cc (right): https://codereview.chromium.org/2124633002/diff/130011/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:142: test_dir = no_alpha_dir; The last two lines should just be: const char* test_dir = no_alpha_dir; https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... File gpu/config/gpu_driver_bug_workaround_type.h (right): https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... gpu/config/gpu_driver_bug_workaround_type.h:69: disable_transparent_visuals) \ As Corentin pointed out elsewhere, changing the sense of this driver bug workaround to "use_transparent_visuals" would make it more clear on which platforms it's enabled. The "exceptions" field wouldn't be needed in gpu_driver_bug_list_json.cc.
Thx for the review. Please see my replies. https://codereview.chromium.org/2124633002/diff/130011/extensions/browser/api... File extensions/browser/api/app_window/app_window_apitest.cc (right): https://codereview.chromium.org/2124633002/diff/130011/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:142: test_dir = no_alpha_dir; On 2016/07/07 22:23:40, Ken Russell wrote: > The last two lines should just be: > > const char* test_dir = no_alpha_dir; I did that to avoid a potential unused error but I will try what you suggested maybe the try bots will just pass. https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... File gpu/config/gpu_driver_bug_workaround_type.h (right): https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... gpu/config/gpu_driver_bug_workaround_type.h:69: disable_transparent_visuals) \ On 2016/07/07 22:23:40, Ken Russell wrote: > As Corentin pointed out elsewhere, changing the sense of this driver bug > workaround to "use_transparent_visuals" would make it more clear on which > platforms it's enabled. The "exceptions" field wouldn't be needed in > gpu_driver_bug_list_json.cc. My understanding was that Corentin wanted to have it changed only in the function, so I did it in Patch Set 6: https://codereview.chromium.org/2124633002/diff2/80001:100001/ui/base/x/x11_u... For the workaround name I would like to keep the current name since it is coherent with other workaround names. For example, using transparent visuals is the expected working usage, but if there is a bug then it disables it.
https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... File gpu/config/gpu_driver_bug_workaround_type.h (right): https://codereview.chromium.org/2124633002/diff/130011/gpu/config/gpu_driver_... gpu/config/gpu_driver_bug_workaround_type.h:69: disable_transparent_visuals) \ On 2016/07/08 09:52:53, Julien Isorce wrote: > On 2016/07/07 22:23:40, Ken Russell wrote: > > As Corentin pointed out elsewhere, changing the sense of this driver bug > > workaround to "use_transparent_visuals" would make it more clear on which > > platforms it's enabled. The "exceptions" field wouldn't be needed in > > gpu_driver_bug_list_json.cc. > > My understanding was that Corentin wanted to have it changed only in the > function, so I did it in Patch Set 6: > https://codereview.chromium.org/2124633002/diff2/80001:100001/ui/base/x/x11_u... > > For the workaround name I would like to keep the current name since it is > coherent with other workaround names. For example, using transparent visuals is > the expected working usage, but if there is a bug then it disables it. > OK. I'm not 100% convinced that the future direction is to always use transparent visuals, but either way is fine. Note that there is precedence in this file for the "use_" naming convention.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from cwallez@chromium.org Link to the patchset: https://codereview.chromium.org/2124633002/#ps130011 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, cwallez@chromium.org Link to the patchset: https://codereview.chromium.org/2124633002/#ps150001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on NVIDIA drivers. BUG=369209 R=kbr@chromium.org, piman@chromium.org, sadrul@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, piman@chromium.org, sadrul@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, piman@chromium.org, sadrul@chromium.org, zmo@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=jam@chromium.org, kbr@chromium.org, sadrul@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
j.isorce@samsung.com changed reviewers: + jam@chromium.org - cwallez@chromium.org, piman@chromium.org, zmo@chromium.org
On 2016/07/13 09:43:48, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) Hi Jam, please have a look to the change in extensions/browser/api/app_window/app_window_apitest.cc ? Thx.
On 2016/07/13 15:17:35, Julien Isorce wrote: > On 2016/07/13 09:43:48, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > Hi Jam, please have a look to the change in > extensions/browser/api/app_window/app_window_apitest.cc ? Thx. Please pick an owner from extensions/
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=jam@chromium.org, kbr@chromium.org, sadrul@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
j.isorce@samsung.com changed reviewers: + tapted@chromium.org - jam@chromium.org
On 2016/07/13 19:20:34, jam wrote: > On 2016/07/13 15:17:35, Julien Isorce wrote: > > On 2016/07/13 09:43:48, commit-bot: I haz the power wrote: > > > Try jobs failed on following builders: > > > chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, > > > > > > http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) > > > > Hi Jam, please have a look to the change in > > extensions/browser/api/app_window/app_window_apitest.cc ? Thx. > > Please pick an owner from extensions/ Ok I added @tapted instead. Need also review from @sadrul for ui changes. Thx.
app_window_apitest.cc lgtm with nits https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... File extensions/browser/api/app_window/app_window_apitest.cc (right): https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:137: const char* no_alpha_dir = these should be const char kNoAlphaDir[] = .. (or possibly `const char* const`, but currently they are non-const variables, which isn't right). https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:142: test_dir = no_alpha_dir; It looks weird to initialize it with has_alpha_dir and immediately replace it with no_alpha_dir - I'm guessing you did this to get around an unused variable warning. The less confusing way to do that is ALLOW_UNUSED_LOCAL(kHasAlphaDir); const char* test_dir = kNoAlphaDir; (ALLOW_UNUSED_LOCAL is in base/compiler_specific.h) https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:156: switches::kWindowDepth)) { nit: This outer `if` isn't needed. I'd just write if (base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( switches::kWindowDepth) == "32") test_dir = kHasAlphaDir
Thx for the review and the detailed suggestions. https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... File extensions/browser/api/app_window/app_window_apitest.cc (right): https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:137: const char* no_alpha_dir = On 2016/07/14 23:37:17, tapted wrote: > these should be > > const char kNoAlphaDir[] = .. > > (or possibly `const char* const`, but currently they are non-const variables, > which isn't right). Done. https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:142: test_dir = no_alpha_dir; On 2016/07/14 23:37:17, tapted wrote: > It looks weird to initialize it with has_alpha_dir and immediately replace it > with no_alpha_dir - I'm guessing you did this to get around an unused variable > warning. The less confusing way to do that is > > ALLOW_UNUSED_LOCAL(kHasAlphaDir); > const char* test_dir = kNoAlphaDir; > > (ALLOW_UNUSED_LOCAL is in base/compiler_specific.h) Done. https://codereview.chromium.org/2124633002/diff/150001/extensions/browser/api... extensions/browser/api/app_window/app_window_apitest.cc:156: switches::kWindowDepth)) { On 2016/07/14 23:37:17, tapted wrote: > nit: This outer `if` isn't needed. I'd just write > > if (base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( > switches::kWindowDepth) == "32") > test_dir = kHasAlphaDir > Done.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, cwallez@chromium.org, tapted@chromium.org Link to the patchset: https://codereview.chromium.org/2124633002/#ps170001 (title: "Rebase and addressed remarks from tapted")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
content/browser/browser_main_loop.cc
ui/base/x/x11_util.cc
ui/base/x/x11_util_internal.h
ui/gfx/x/x11_switches.cc
ui/gfx/x/x11_switches.h
ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
ui/views/widget/widget_unittest.cc
lgtm https://codereview.chromium.org/2124633002/diff/170001/ui/views/widget/deskto... File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/2124633002/diff/170001/ui/views/widget/deskto... ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1150: ui::ChooseVisualForWindow(true, &visual, &depth); true /* enable_transparent_visuals */ In old code, this used to default to false, yes?
On 2016/07/15 15:12:13, sadrul wrote: > lgtm > > https://codereview.chromium.org/2124633002/diff/170001/ui/views/widget/deskto... > File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): > > https://codereview.chromium.org/2124633002/diff/170001/ui/views/widget/deskto... > ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1150: > ui::ChooseVisualForWindow(true, &visual, &depth); > true /* enable_transparent_visuals */ > > In old code, this used to default to false, yes? Yes but this call happens after the one from https://codereview.chromium.org/2124633002/patch/170001/180001 and ui::ChooseVisualForWindow caches the depth. Thx for the review.
The CQ bit was checked by j.isorce@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
j.isorce@samsung.com changed reviewers: + piman@chromium.org
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
content/browser/browser_main_loop.cc
Hi Antoine, please have a look. Thx
lgtm
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Your CL relies on deprecated CQ feature(s):
* Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
tryserver.chromium.linux
tryserver.chromium.mac
tryserver.chromium.win
For more details, see http://crbug.com/617627.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Hi, I have added 2 tests, please have a look. Thx
Thanks for adding the tests. LGTM
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org, tapted@chromium.org, cwallez@chromium.org, piman@chromium.org, kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2124633002/#ps310001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #17 (id:310001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ==========
Message was sent while issue was closed.
Patchset 17 (id:??) landed as https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505}
Message was sent while issue was closed.
On 2016/07/20 06:36:29, commit-bot: I haz the power wrote: > Patchset 17 (id:??) landed as > https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 > Cr-Commit-Position: refs/heads/master@{#406505} I believe these test are failing on Android and Linux GPU.FYI bots.
Message was sent while issue was closed.
On 2016/07/21 22:18:53, ynovikov1 wrote: > On 2016/07/20 06:36:29, commit-bot: I haz the power wrote: > > Patchset 17 (id:??) landed as > > https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 > > Cr-Commit-Position: refs/heads/master@{#406505} > > I believe these test are failing on Android and Linux GPU.FYI bots. First failing builds: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A...
Message was sent while issue was closed.
On 2016/07/21 22:18:53, ynovikov1 wrote: > On 2016/07/20 06:36:29, commit-bot: I haz the power wrote: > > Patchset 17 (id:??) landed as > > https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 > > Cr-Commit-Position: refs/heads/master@{#406505} > > I believe these test are failing on Android and Linux GPU.FYI bots. First failing builds: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A...
Message was sent while issue was closed.
A revert of this CL (patchset #17 id:310001) has been created in https://codereview.chromium.org/2171023002/ by jmadill@chromium.org. The reason for reverting is: Seems to break the Android and Linux GPU fyi bots: https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... https://build.chromium.org/p/chromium.gpu.fyi/builders/Linux%20Release%20%28A... https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%2... <couple others> GpuProcess.no_transparent_visuals_gpu_process Failure: disable_transparent_visuals is missing in Browser process workarounds: [u'broken_egl_image_ref_counting', u'clear_uniforms_before_first_program_use', u'disable_blend_equation_advanced', u'disable_chromium_framebuffer_multisample', u'disable_depth_texture', u'disable_discard_framebuffer', u'disable_framebuffer_cmaa', u'disable_program_cache', u'force_cube_map_positive_x_allocation', u'max_copy_texture_chromium_size_1048576', u'max_texture_size_limit_4096', u'scalarize_vec_and_mat_constructor_args', u'unbind_attachments_on_bound_render_fbo_delete', u'unbind_egl_context_to_flush_driver_caches', u'use_virtualized_gl_contexts', u'wake_up_gpu_before_drawing'] [ FAILED ] GpuProcess.no_transparent_visuals_gpu_process (5860 ms) .
Message was sent while issue was closed.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ==========
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by j.isorce@samsung.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by j.isorce@samsung.com
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org, cwallez@chromium.org, piman@chromium.org Link to the patchset: https://codereview.chromium.org/2124633002/#ps350001 (title: "Just make sure the new gpu driver workaround exist in second test instead of using fake values")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ==========
Message was sent while issue was closed.
Committed patchset #19 (id:350001)
Message was sent while issue was closed.
Description was changed from ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Cr-Commit-Position: refs/heads/master@{#406505} ========== to ========== Add new gpu driver bug workaround DISABLE_TRANSPARENT_VISUALS This is for better polish in the UI but it fixes a drag image issue on Linux crbug.com/593256 . Also add a kGpuDriverBugListJson entry to automatically disable transparent visuals on all drivers (especially the proprietary NVIDIA driver) except for opensource drivers (i.e. Mesa based drivers). BUG=369209 R=kbr@chromium.org, sadrul@chromium.org, tapted@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/71b2517dd4cd620a56ca6f13571129c6aee30b42 Committed: https://crrev.com/102b4b07240352221cf4256ff84bf71e2f9189a2 Cr-Original-Commit-Position: refs/heads/master@{#406505} Cr-Commit-Position: refs/heads/master@{#407137} ==========
Message was sent while issue was closed.
Patchset 19 (id:??) landed as https://crrev.com/102b4b07240352221cf4256ff84bf71e2f9189a2 Cr-Commit-Position: refs/heads/master@{#407137} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
