Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2173883003: Fix gyp compile failures caused by moving broadcastchannel code. (Closed)

Created:
4 years, 5 months ago by Marijn Kruisselbrink
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gyp compile failures caused by moving broadcastchannel code. I don't understand how gyp works with mojo bindings, but this seems to fix some compile failures introduced in https://codereview.chromium.org/2158913006 BUG=630666 Committed: https://crrev.com/bf2e315db64d351c1504d6ffe89f4a4cdb063e2c Cr-Commit-Position: refs/heads/master@{#407286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/platform/blink_platform.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Marijn Kruisselbrink
4 years, 5 months ago (2016-07-22 21:01:58 UTC) #5
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-22 21:17:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173883003/1
4 years, 5 months ago (2016-07-22 21:18:34 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 22:45:56 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 22:48:27 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf2e315db64d351c1504d6ffe89f4a4cdb063e2c
Cr-Commit-Position: refs/heads/master@{#407286}

Powered by Google App Engine
This is Rietveld 408576698