Move BroadcastChannel browser code from components/ to content/browser.

Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink. This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
Committed: https://crrev.com/ad9b0483a8ad19740e2438052b9b88077ab966e0
Cr-Commit-Position: refs/heads/master@{#406852}

[jam, 2016-07-20 23:53:31]

The CQ bit was checked by jam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 23:54:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jam, 2016-07-20 23:54:20]

Description was changed from

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
==========

to

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
==========

[jam, 2016-07-20 23:54:20]

jam@chromium.org changed reviewers:
+ jochen@chromium.org, nasko@chromium.org

[jam, 2016-07-21 00:28:55]

nasko: security owner for the mojom move
jochen: the rest

[nasko, 2016-07-21 00:42:04]

Mojom move and content/ LGTM.

[commit-bot: I haz the power, 2016-07-21 01:14:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:14:38]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-07-21 08:20:32]

WebKit/Source LGTM

[jochen (gone - plz use gerrit), 2016-07-21 08:30:33]

jochen@chromium.org changed reviewers:
+ haraken@chromium.org

[jochen (gone - plz use gerrit), 2016-07-21 08:30:34]

lgtm

[blundell, 2016-07-21 08:40:46]

blundell@chromium.org changed reviewers:
+ blundell@chromium.org

[blundell, 2016-07-21 08:40:46]

Thanks for making this change, John!

[jam, 2016-07-21 15:15:12]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-07-21 15:15:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 15:19:49]

Description was changed from

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
==========

to

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
==========

[commit-bot: I haz the power, 2016-07-21 15:19:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-21 15:21:25]

Description was changed from

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070
==========

to

==========
Move BroadcastChannel browser code from components/ to content/browser.

It's only used by content/browser, so it can stay there.

Also update URL related typemaps so that they can be used by mojoms in Blink.
This is copied from https://codereview.chromium.org/2043753002/.

BUG=161070

Committed: https://crrev.com/ad9b0483a8ad19740e2438052b9b88077ab966e0
Cr-Commit-Position: refs/heads/master@{#406852}
==========

[commit-bot: I haz the power, 2016-07-21 15:21:26]

Patchset 1 (id:??) landed as
https://crrev.com/ad9b0483a8ad19740e2438052b9b88077ab966e0
Cr-Commit-Position: refs/heads/master@{#406852}

[Peter Kasting, 2016-07-27 02:45:07]

I *think* this started causing the following warnings in my local MSVC build
(but I didn't back the change out to test; it just looked like the most likely
culprit).  Are you aware of this?  Can you look into it?  Would you like me to
file a bug?

1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?deref@?$RefCounted@VSecurityOrigin@blink@@@WTF@@QEBAXXZ (public: void __cdecl
WTF::RefCounted<class blink::SecurityOrigin>::deref(void)const ) imported in
function "void __cdecl WTF::derefIfNotNull<class blink::SecurityOrigin>(class
blink::SecurityOrigin *)"
(??$derefIfNotNull@VSecurityOrigin@blink@@@WTF@@YAXPEAVSecurityOrigin@blink@@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?createUnique@SecurityOrigin@blink@@SA?AV?$PassRefPtr@VSecurityOrigin@blink@@@WTF@@XZ
(public: static class WTF::PassRefPtr<class blink::SecurityOrigin> __cdecl
blink::SecurityOrigin::createUnique(void)) imported in function "public: static
bool __cdecl mojo::StructTraits<class url::mojom::blink::Origin,class
WTF::RefPtr<class blink::SecurityOrigin> >::Read(class
url::mojom::blink::OriginDataView,class WTF::RefPtr<class blink::SecurityOrigin>
*)"
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?create@SecurityOrigin@blink@@SA?AV?$PassRefPtr@VSecurityOrigin@blink@@@WTF@@AEBVString@4@0H@Z
(public: static class WTF::PassRefPtr<class blink::SecurityOrigin> __cdecl
blink::SecurityOrigin::create(class WTF::String const &,class WTF::String const
&,int)) imported in function "public: static bool __cdecl
mojo::StructTraits<class url::mojom::blink::Origin,class WTF::RefPtr<class
blink::SecurityOrigin> >::Read(class url::mojom::blink::OriginDataView,class
WTF::RefPtr<class blink::SecurityOrigin> *)"
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?protocol@SecurityOrigin@blink@@QEBA?AVString@WTF@@XZ (public: class WTF::String
__cdecl blink::SecurityOrigin::protocol(void)const ) imported in function
"public: static class WTF::String __cdecl mojo::StructTraits<class
url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
>::scheme(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
(?scheme@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA?AVString@WTF@@AEBV?$RefPtr@VSecurityOrigin@blink@@@4@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?host@SecurityOrigin@blink@@QEBA?AVString@WTF@@XZ (public: class WTF::String
__cdecl blink::SecurityOrigin::host(void)const ) imported in function "public:
static class WTF::String __cdecl mojo::StructTraits<class
url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
>::host(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
(?host@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA?AVString@WTF@@AEBV?$RefPtr@VSecurityOrigin@blink@@@4@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?effectivePort@SecurityOrigin@blink@@QEBAGXZ (public: unsigned short __cdecl
blink::SecurityOrigin::effectivePort(void)const ) imported in function "public:
static unsigned short __cdecl mojo::StructTraits<class
url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
>::port(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
(?port@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SAGAEBV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
1>
1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
?isUnique@SecurityOrigin@blink@@QEBA_NXZ (public: bool __cdecl
blink::SecurityOrigin::isUnique(void)const ) imported in function "public:
static bool __cdecl mojo::StructTraits<class url::mojom::blink::Origin,class
WTF::RefPtr<class blink::SecurityOrigin> >::Read(class
url::mojom::blink::OriginDataView,class WTF::RefPtr<class blink::SecurityOrigin>
*)"
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
1>

[ncarter (slow), 2016-07-27 18:29:05]

On 2016/07/27 02:45:07, Peter Kasting wrote:
> I *think* this started causing the following warnings in my local MSVC build
> (but I didn't back the change out to test; it just looked like the most likely
> culprit).  Are you aware of this?  Can you look into it?  Would you like me to
> file a bug?
> 
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
> ?deref@?$RefCounted@VSecurityOrigin@blink@@@WTF@@QEBAXXZ (public: void __cdecl
> WTF::RefCounted<class blink::SecurityOrigin>::deref(void)const ) imported in
> function "void __cdecl WTF::derefIfNotNull<class blink::SecurityOrigin>(class
> blink::SecurityOrigin *)"
>
(??$derefIfNotNull@VSecurityOrigin@blink@@@WTF@@YAXPEAVSecurityOrigin@blink@@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
>
?createUnique@SecurityOrigin@blink@@SA?AV?$PassRefPtr@VSecurityOrigin@blink@@@WTF@@XZ
> (public: static class WTF::PassRefPtr<class blink::SecurityOrigin> __cdecl
> blink::SecurityOrigin::createUnique(void)) imported in function "public:
static
> bool __cdecl mojo::StructTraits<class url::mojom::blink::Origin,class
> WTF::RefPtr<class blink::SecurityOrigin> >::Read(class
> url::mojom::blink::OriginDataView,class WTF::RefPtr<class
blink::SecurityOrigin>
> *)"
>
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
>
?create@SecurityOrigin@blink@@SA?AV?$PassRefPtr@VSecurityOrigin@blink@@@WTF@@AEBVString@4@0H@Z
> (public: static class WTF::PassRefPtr<class blink::SecurityOrigin> __cdecl
> blink::SecurityOrigin::create(class WTF::String const &,class WTF::String
const
> &,int)) imported in function "public: static bool __cdecl
> mojo::StructTraits<class url::mojom::blink::Origin,class WTF::RefPtr<class
> blink::SecurityOrigin> >::Read(class url::mojom::blink::OriginDataView,class
> WTF::RefPtr<class blink::SecurityOrigin> *)"
>
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
> ?protocol@SecurityOrigin@blink@@QEBA?AVString@WTF@@XZ (public: class
WTF::String
> __cdecl blink::SecurityOrigin::protocol(void)const ) imported in function
> "public: static class WTF::String __cdecl mojo::StructTraits<class
> url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
> >::scheme(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
>
(?scheme@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA?AVString@WTF@@AEBV?$RefPtr@VSecurityOrigin@blink@@@4@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
> ?host@SecurityOrigin@blink@@QEBA?AVString@WTF@@XZ (public: class WTF::String
> __cdecl blink::SecurityOrigin::host(void)const ) imported in function "public:
> static class WTF::String __cdecl mojo::StructTraits<class
> url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
> >::host(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
>
(?host@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA?AVString@WTF@@AEBV?$RefPtr@VSecurityOrigin@blink@@@4@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
> ?effectivePort@SecurityOrigin@blink@@QEBAGXZ (public: unsigned short __cdecl
> blink::SecurityOrigin::effectivePort(void)const ) imported in function
"public:
> static unsigned short __cdecl mojo::StructTraits<class
> url::mojom::blink::Origin,class WTF::RefPtr<class blink::SecurityOrigin>
> >::port(class WTF::RefPtr<class blink::SecurityOrigin> const &)"
>
(?port@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SAGAEBV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
> 1>
> 1>broadcast_channel.mojom-blink.obj : warning LNK4217: locally defined symbol
> ?isUnique@SecurityOrigin@blink@@QEBA_NXZ (public: bool __cdecl
> blink::SecurityOrigin::isUnique(void)const ) imported in function "public:
> static bool __cdecl mojo::StructTraits<class url::mojom::blink::Origin,class
> WTF::RefPtr<class blink::SecurityOrigin> >::Read(class
> url::mojom::blink::OriginDataView,class WTF::RefPtr<class
blink::SecurityOrigin>
> *)"
>
(?Read@?$StructTraits@VOrigin@blink@mojom@url@@V?$RefPtr@VSecurityOrigin@blink@@@WTF@@@mojo@@SA_NVOriginDataView@blink@mojom@url@@PEAV?$RefPtr@VSecurityOrigin@blink@@@WTF@@@Z)
> 1>

peter: I see that too, and just filed crbug.com/632082