Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2173843002: binding: Removes createClosure(). (Closed)

Created:
4 years, 5 months ago by Yuki
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

binding: Removes createClosure(). createClosure is used only at ScriptFunction::bindToV8Function, and it shouldn't be used widely because it doesn't create a v8::FunctionTemplate or reuse it. Thus, this CL removes it. BUG=626266 Committed: https://crrev.com/19832e78567e1a69a9d1f99761494b54b9aa67fa Cr-Commit-Position: refs/heads/master@{#407451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h View 2 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Yuki
Could you review this CL?
4 years, 5 months ago (2016-07-22 14:02:03 UTC) #3
haraken
LGTM
4 years, 5 months ago (2016-07-22 19:30:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173843002/1
4 years, 5 months ago (2016-07-25 08:37:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 11:52:27 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 11:54:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19832e78567e1a69a9d1f99761494b54b9aa67fa
Cr-Commit-Position: refs/heads/master@{#407451}

Powered by Google App Engine
This is Rietveld 408576698