Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/ScriptFunction.h

Issue 2173843002: binding: Removes createClosure(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 // // garbage-collected. 46 // // garbage-collected.
47 // static v8::Local<v8::Function> createFunction(ScriptState* scriptState) 47 // static v8::Local<v8::Function> createFunction(ScriptState* scriptState)
48 // { 48 // {
49 // DerivedFunction* self = new DerivedFunction(scriptState); 49 // DerivedFunction* self = new DerivedFunction(scriptState);
50 // return self->bindToV8Function(); 50 // return self->bindToV8Function();
51 // } 51 // }
52 // }; 52 // };
53 class CORE_EXPORT ScriptFunction : public GarbageCollectedFinalized<ScriptFuncti on> { 53 class CORE_EXPORT ScriptFunction : public GarbageCollectedFinalized<ScriptFuncti on> {
54 public: 54 public:
55 virtual ~ScriptFunction() { } 55 virtual ~ScriptFunction() { }
56 ScriptState* getScriptState() const { return m_scriptState.get(); }
57 DEFINE_INLINE_VIRTUAL_TRACE() { } 56 DEFINE_INLINE_VIRTUAL_TRACE() { }
58 57
59 protected: 58 protected:
60 explicit ScriptFunction(ScriptState* scriptState) 59 explicit ScriptFunction(ScriptState* scriptState)
61 : m_scriptState(scriptState) 60 : m_scriptState(scriptState)
61 #if ENABLE(ASSERT)
62 , m_bindToV8FunctionAlreadyCalled(false)
63 #endif
62 { 64 {
63 } 65 }
64 66
67 ScriptState* getScriptState() const { return m_scriptState.get(); }
68
65 v8::Local<v8::Function> bindToV8Function(); 69 v8::Local<v8::Function> bindToV8Function();
66 70
67 private: 71 private:
68 virtual ScriptValue call(ScriptValue) = 0; 72 virtual ScriptValue call(ScriptValue) = 0;
69 static void callCallback(const v8::FunctionCallbackInfo<v8::Value>&); 73 static void callCallback(const v8::FunctionCallbackInfo<v8::Value>&);
70 74
71 RefPtr<ScriptState> m_scriptState; 75 RefPtr<ScriptState> m_scriptState;
76 #if ENABLE(ASSERT)
77 // bindToV8Function must not be called twice.
78 bool m_bindToV8FunctionAlreadyCalled;
79 #endif
72 }; 80 };
73 81
74 } // namespace blink 82 } // namespace blink
75 83
76 #endif 84 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptFunction.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698