third_party/WebKit/Source/core/inspector/browser_protocol.json - Issue 2173783002: Adds visual viewport size override to DevTools Emulation protocol.

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2173783002: Adds visual viewport size override to DevTools Emulation protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/emulation/device-emulation-visual-viewport-size-expected.txt ('k') | third_party/WebKit/public/web/WebDeviceEmulationParams.h » ('j') | third_party/WebKit/public/web/WebDeviceEmulationParams.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/browser_protocol.json

diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json

index 2361dfa252f87ab2e921a67e68b2ebf9b5b30388..e509d84bf315658c53ec1940fa5ec2660625112b 100644

--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json

+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json

@@ -722,7 +722,7 @@

"commands": [

{

"name": "setDeviceMetricsOverride",

- "description": "Overrides the values of device screen dimensions (window.screen.width, window.screen.height, window.innerWidth, window.innerHeight, and \"device-width\"/\"device-height\"-related CSS media query results).",

+ "description": "Overrides the values of device, screen, and viewport dimensions (including window.screen.width, window.screen.height, window.innerWidth, window.innerHeight, and \"device-width\"/\"device-height\"-related CSS media query results).",

"parameters": [

{ "name": "width", "type": "integer", "description": "Overriding width value in pixels (minimum 0, maximum 10000000). 0 disables the override." },

{ "name": "height", "type": "integer", "description": "Overriding height value in pixels (minimum 0, maximum 10000000). 0 disables the override." },

@@ -736,7 +736,9 @@

{ "name": "screenHeight", "type": "integer", "optional": true, "description": "Overriding screen height value in pixels (minimum 0, maximum 10000000). Only used for |mobile==true|." },

{ "name": "positionX", "type": "integer", "optional": true, "description": "Overriding view X position on screen in pixels (minimum 0, maximum 10000000). Only used for |mobile==true|." },

{ "name": "positionY", "type": "integer", "optional": true, "description": "Overriding view Y position on screen in pixels (minimum 0, maximum 10000000). Only used for |mobile==true|." },

- { "name": "screenOrientation", "$ref": "ScreenOrientation", "optional": true, "description": "Screen orientation override." }

+ { "name": "screenOrientation", "$ref": "ScreenOrientation", "optional": true, "description": "Screen orientation override." },

+ { "name": "visualViewportWidth", "type": "integer", "optional": true, "description": "Override height of visual viewport (pixels, minimum 0, maximum 10000000). Optional, defaults to |width|." },

+ { "name": "visualViewportHeight", "type": "integer", "optional": true, "description": "Override height of visual viewport (pixels, minimum 0, maximum 10000000). Optional, defaults to |height|." }

"handlers": ["browser"]