Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: third_party/WebKit/public/web/WebDeviceEmulationParams.h

Issue 2173783002: Adds visual viewport size override to DevTools Emulation protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebDeviceEmulationParams.h
diff --git a/third_party/WebKit/public/web/WebDeviceEmulationParams.h b/third_party/WebKit/public/web/WebDeviceEmulationParams.h
index 85f9f7c466540104fcd230c409a7f8011188a696..1ab462a2341c70dad54b866fea7ab92872cc3416 100644
--- a/third_party/WebKit/public/web/WebDeviceEmulationParams.h
+++ b/third_party/WebKit/public/web/WebDeviceEmulationParams.h
@@ -53,6 +53,10 @@ struct WebDeviceEmulationParams {
// Screen orientation angle, used together with screenOrientationType.
int screenOrientationAngle;
+ // Emulated visual viewport size. |x == 0| or |y == 0| disables the override
dgozman 2016/07/25 22:13:54 nit: x, y -> width, height
Eric Seckler 2016/07/26 08:33:50 Done.
+ // for the respective coordinate.
+ WebSize visualViewportSize;
+
WebDeviceEmulationParams()
: screenPosition(Desktop)
, deviceScaleFactor(0)
@@ -66,7 +70,8 @@ inline bool operator==(const WebDeviceEmulationParams& a, const WebDeviceEmulati
{
return a.screenPosition == b.screenPosition && a.screenSize == b.screenSize && a.viewPosition == b.viewPosition && a.deviceScaleFactor == b.deviceScaleFactor
&& a.viewSize == b.viewSize && a.fitToView == b.fitToView && a.offset == b.offset && a.scale == b.scale
- && a.screenOrientationType == b.screenOrientationType && a.screenOrientationAngle == b.screenOrientationAngle;
+ && a.screenOrientationType == b.screenOrientationType && a.screenOrientationAngle == b.screenOrientationAngle
+ && a.visualViewportSize == b.visualViewportSize;
}
inline bool operator!=(const WebDeviceEmulationParams& a, const WebDeviceEmulationParams& b)
« no previous file with comments | « third_party/WebKit/Source/core/inspector/browser_protocol.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698