Reland: Redirect syncing users without sync passphrase to passwords.google.com

Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to https://passwords.google.com instead of natively displaying passwords. The changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
Committed: https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10
Cr-Commit-Position: refs/heads/master@{#407440}

[dozsa, 2016-07-22 08:48:45]

Description was changed from

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
==========

to

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

CQ_INCLUDE_TRYBOTS=linux_android_dbg_ng

BUG=623488
==========

[dozsa, 2016-07-22 09:08:42]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:09:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:09:03]

Dry run: Your CL can not be processed by CQ because of:
 * Failed to parse additional trybots

[dozsa, 2016-07-22 09:09:27]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:09:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:09:45]

Dry run: Your CL can not be processed by CQ because of:
 * Failed to parse additional trybots

[dozsa, 2016-07-22 09:10:15]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:10:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:10:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:10:35]

Dry run: Your CL can not be processed by CQ because of:
 * Failed to parse additional trybots

[dozsa, 2016-07-22 09:18:19]

Patchset #2 (id:20001) has been deleted

[dozsa, 2016-07-22 11:40:54]

Patchset #3 (id:60001) has been deleted

[dozsa, 2016-07-25 08:09:12]

dozsa@google.com changed reviewers:
+ bauerb@chromium.org, vabr@chromium.org

[dozsa, 2016-07-25 08:09:51]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 08:09:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 08:10:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 08:10:01]

Dry run: Your CL can not be processed by CQ because of:
 * Failed to parse additional trybots

[dozsa, 2016-07-25 08:17:37]

Description was changed from

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

CQ_INCLUDE_TRYBOTS=linux_android_dbg_ng

BUG=623488
==========

to

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
==========

[dozsa, 2016-07-25 08:17:47]

The CQ bit was checked by dozsa@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 08:18:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bernhard Bauer, 2016-07-25 08:21:20]

lgtm

[vabr (Chromium), 2016-07-25 08:38:28]

Hi Paula,

The link to observe after landing is:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29.
On that page you can locate the build with your change in the blamelist (at some
point after landing in the "Currently Building Section"), and inspect that one
for specific failures. You should also automatically get an e-mail if your CL is
in a blamelist of a failing bot.

Cheers,
vaclav

[commit-bot: I haz the power, 2016-07-25 09:22:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 09:22:54]

Dry run: This issue passed the CQ dry run.

[vabr (Chromium), 2016-07-25 09:44:49]

The linux_android_dbg_ng trybot seems to be failing with an unrelated issue. I
would recommend to land this now and just watch
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29
(and the tree https://build.chromium.org/p/chromium/console?reload=60 in
general) for failures.

Cheers,
Vaclav

[dozsa, 2016-07-25 10:04:00]

The CQ bit was checked by dozsa@google.com

[commit-bot: I haz the power, 2016-07-25 10:04:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 10:07:44]

Description was changed from

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
==========

to

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
==========

[commit-bot: I haz the power, 2016-07-25 10:07:45]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-07-25 10:09:02]

Description was changed from

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488
==========

to

==========
Reland: Redirect syncing users without sync passphrase to passwords.google.com

This CL redirects syncing users without a sync passphrase to
https://passwords.google.com instead of natively displaying passwords. The
changes created in this CL are hidden behind the ViewPasswords feature.

This is a reland of https://codereview.chromium.org/2092723002/

BUG=623488

Committed: https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10
Cr-Commit-Position: refs/heads/master@{#407440}
==========

[commit-bot: I haz the power, 2016-07-25 10:09:03]

Patchset 3 (id:??) landed as
https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10
Cr-Commit-Position: refs/heads/master@{#407440}

[vabr (Chromium), 2016-07-25 14:05:50]

On 2016/07/25 10:09:03, commit-bot: I haz the power wrote:
> Patchset 3 (id:??) landed as
> https://crrev.com/86fa8831dcb7154bd60f77a532953517797d4f10
> Cr-Commit-Position: refs/heads/master@{#407440}

https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...
is green, yay! :)