Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2173613002: Converted Observatory nav-bar element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -75 lines) Patch
M runtime/observatory/lib/elements.dart View 3 chunks +3 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 3 chunks +4 lines, -3 lines 0 comments Download
A runtime/observatory/lib/src/elements/nav/bar.dart View 1 chunk +83 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 chunk +0 lines, -54 lines 0 comments Download
M runtime/observatory/lib/src/elements/script_inset.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/bar/element_test.dart View 1 chunk +8 lines, -6 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/bar/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-22 00:41:44 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-22 13:45:46 UTC) #3
rmacnak
lgtm
4 years, 5 months ago (2016-07-22 20:15:27 UTC) #4
cbernaschina
4 years, 5 months ago (2016-07-22 20:53:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5680532769b9fa8fcce96a2556fb970ca3d4cdb2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698