runtime/observatory/lib/src/elements/script_inset.dart - Issue 2173613002: Converted Observatory nav-bar element - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(698)

My Issues | Starred Open | Closed | All

Unified Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 2173613002: Converted Observatory nav-bar element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « runtime/observatory/lib/src/elements/nav_bar.html ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/script_inset.dart

diff --git a/runtime/observatory/lib/src/elements/script_inset.dart b/runtime/observatory/lib/src/elements/script_inset.dart

index 5776bc4e26f09725aaebdc4d390468b38fccdf29..d4f2899e33807c16f490094bfa6071f93cb00c97 100644

--- a/runtime/observatory/lib/src/elements/script_inset.dart

+++ b/runtime/observatory/lib/src/elements/script_inset.dart

@@ -8,7 +8,6 @@ import 'dart:async';

import 'dart:html';

import 'dart:math';

import 'observatory_element.dart';

-import 'nav_bar.dart';

import 'service_ref.dart';

import 'package:observatory/service.dart';

import 'package:observatory/utils.dart';

@@ -984,7 +983,8 @@ class ScriptInsetElement extends ObservatoryElement {

return 5;

}

const padding = 5;

- const navbarHeight = NavBarElement.height;

+ // TODO (cbernaschina) check if this is needed.

+ const navbarHeight = 40;

var rect = getBoundingClientRect();

var buttonHeight = element.clientHeight;

return min(max(0, navbarHeight - rect.top) + padding,

« no previous file with comments | « runtime/observatory/lib/src/elements/nav_bar.html ('k') | runtime/observatory/observatory_sources.gypi » ('j') | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698