Cleanup of code that converts from GPU-backed resources to SkImageInfo

Cleanup of code that converts from GPU-backed resources to SkImageInfo

Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).

With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2173513002

Committed: https://skia.googlesource.com/skia/+/396fcdba14a0101ed43dcc3863585bf50c4ed6cc

[Brian Osman, 2016-07-21 20:53:50]

Description was changed from

==========
Cleanup of code that converts from GPU-backed resources to SkImageInfo

Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).

With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.

BUG=skia:
==========

to

==========
Cleanup of code that converts from GPU-backed resources to SkImageInfo

Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).

With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2173513002
==========

[Brian Osman, 2016-07-21 20:57:07]

brianosman@google.com changed reviewers:
+ bsalomon@google.com, robertphillips@google.com

[Brian Osman, 2016-07-21 20:57:08]

https://codereview.chromium.org/2173513002/diff/1/src/image/SkImage_Gpu.cpp
File src/image/SkImage_Gpu.cpp (right):

https://codereview.chromium.org/2173513002/diff/1/src/image/SkImage_Gpu.cpp#n...
src/image/SkImage_Gpu.cpp:51: return SkImageInfo::Make(fTexture->width(),
fTexture->height(), ct, fAlphaType, fColorSpace);
This is now slightly different semantically - it used to call isOpaque
so the resulting info would only be opaque or premul. I see no reason
to keep that behavior.

https://codereview.chromium.org/2173513002/diff/1/src/image/SkImage_Gpu.cpp#n...
src/image/SkImage_Gpu.cpp:330: SkImageInfo info = as_IB(this)->onImageInfo();
Similar to above. We already have the *correct* alpha type!

[bsalomon, 2016-07-21 21:01:35]

nice! lgtm

[Brian Osman, 2016-07-21 21:05:30]

The CQ bit was checked by brianosman@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 21:05:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 21:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 21:32:56]

Dry run: This issue passed the CQ dry run.

[Brian Osman, 2016-07-22 13:25:12]

The CQ bit was checked by brianosman@google.com

[commit-bot: I haz the power, 2016-07-22 13:25:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 13:26:13]

Description was changed from

==========
Cleanup of code that converts from GPU-backed resources to SkImageInfo

Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).

With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2173513002
==========

to

==========
Cleanup of code that converts from GPU-backed resources to SkImageInfo

Functions like GrMakeInfoFromTexture encouraged incorrect code to be
written. Similarly, the ability to construct an info from any GrSurface
was never going to be correct. Luckily, the only client of that had all
of the correct parameters much higher on the stack (and dictated or
replaced most of the properties of the returned info anyway).

With this, I can finally remove the color space as an output of the
pixel config -> color type conversion, which was never going to be
correct.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2173513002

Committed:
https://skia.googlesource.com/skia/+/396fcdba14a0101ed43dcc3863585bf50c4ed6cc
==========

[commit-bot: I haz the power, 2016-07-22 13:26:14]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/396fcdba14a0101ed43dcc3863585bf50c4ed6cc