Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2170663003: No symlink. The bots are not running hooks anyway. (Closed)

Created:
4 years, 5 months ago by mtklein_C
Modified:
4 years, 5 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

No symlink. The bots are not running hooks anyway. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2170663003 Committed: https://skia.googlesource.com/skia/+/43d707ca931a45f5399d9acf2bdb1a19567a6e67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M DEPS View 3 chunks +3 lines, -3 lines 0 comments Download
D skia View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 2173513002 Patch 1

Messages

Total messages: 9 (4 generated)
mtklein_C
4 years, 5 months ago (2016-07-21 20:07:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2170663003/1
4 years, 5 months ago (2016-07-21 20:07:26 UTC) #5
jcgregorio
lgtm
4 years, 5 months ago (2016-07-21 20:09:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/43d707ca931a45f5399d9acf2bdb1a19567a6e67
4 years, 5 months ago (2016-07-21 20:43:52 UTC) #8
mtklein
4 years, 5 months ago (2016-07-22 00:04:34 UTC) #9
Message was sent while issue was closed. 
On 2016/07/21 20:43:52, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/43d707ca931a45f5399d9acf2bdb1a19567a6e67

Another good reason to revert, from Chrome roll:

----------- licensecheck stderr -----------
find: File system loop detected; `/b/c/b/linux/src/third_party/skia/skia' is
part of the same file system loop as `/b/c/b/linux/src/third_party/skia'.

Powered by Google App Engine
This is Rietveld 408576698