Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2173453002: Resolve URL/target reference at a single point in SVGUseElement (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, chromium-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Resolve URL/target reference at a single point in SVGUseElement The <base> URL can change between the attribute (href) is updated and the shadow tree constructed. This causes confusion in the target resolving code since it can produce different results at different points in time. Only resolve the URL on changes (to 'href'), extract the fragment identifier and store whether the reference is local or not. Refactor the SVGUseElement target element lookup with an eye to future handling of "fragment-only" (local) URLs. This makes the externalDocument in SVGURIReference::targetElementFromIRIString unused, so remove that codepath and simplify the function accordingly. This changes behavior from resolving the URL and target element when needed (depending on when layouts happen), to only when the 'href' is mutated. This new behavior matches Edge, but not Gecko. BUG=601203, 470608 Committed: https://crrev.com/91e189ad391cd78854f71f816c08c08e7bc991a4 Cr-Commit-Position: refs/heads/master@{#407128}

Patch Set 1 #

Patch Set 2 : Add missing expected file #

Total comments: 2

Patch Set 3 : Test touchups #

Messages

Total messages: 17 (12 generated)
fs
I'll fix this ASSERT issue, he said. It'll be easy, he said.
4 years, 5 months ago (2016-07-21 19:59:50 UTC) #6
pdr.
Nice! LGTM https://codereview.chromium.org/2173453002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html File third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html (right): https://codereview.chromium.org/2173453002/diff/20001/third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html#newcode4 third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html:4: <script> Nit: Can you move the script ...
4 years, 5 months ago (2016-07-22 01:41:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173453002/40001
4 years, 5 months ago (2016-07-22 10:29:31 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-22 10:56:14 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 10:58:34 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/91e189ad391cd78854f71f816c08c08e7bc991a4
Cr-Commit-Position: refs/heads/master@{#407128}

Powered by Google App Engine
This is Rietveld 408576698