third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html - Issue 2173453002: Resolve URL/target reference at a single point in SVGUseElement

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert.html

Issue 2173453002: Resolve URL/target reference at a single point in SVGUseElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add missing expected file Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/svg/custom/use-external-base-change-assert-expected.txt » ('j') | third_party/WebKit/LayoutTests/svg/custom/use-external-dynamic-base-change.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg>

	3 <use href="resources/linkingCircle-f.svg#circle-1">

	4 <script>
	pdr. 2016/07/22 01:41:53 Nit: Can you move the script out of the use? I che Nit: Can you move the script out of the use? I checked that it still crashes without the patch.
	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7 var baseElement = document.createElement("base");

	8 baseElement.setAttribute("href", "http://www.example.com/");

	9 document.head.appendChild(baseElement);

	10 </script>

	11 </use>

	12 </svg>

	13 <p>PASS if no assert in debug</p>

OLD	NEW