Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2173413002: Add a test for canceling a pending stylesheet loading of a link element (Closed)

Created:
4 years, 5 months ago by hayato
Modified:
4 years, 5 months ago
Reviewers:
tkent, esprehn
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a test for canceling a pending stylesheet loading of a link element This test should be added together with https://codereview.chromium.org/2171293002 BUG=630141 Committed: https://crrev.com/0d90f310e3bdfc51391a7c34d1982c8f23845090 Cr-Commit-Position: refs/heads/master@{#407439}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
A third_party/WebKit/Source/web/tests/LinkElementLoadingTest.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/web.gypi View 1 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 19 (11 generated)
hayato
fix
4 years, 5 months ago (2016-07-25 07:13:44 UTC) #5
hayato
PTAL
4 years, 5 months ago (2016-07-25 07:14:53 UTC) #10
hayato
https://codereview.chromium.org/2173413002/diff/20001/third_party/WebKit/Source/web/web.gypi File third_party/WebKit/Source/web/web.gypi (right): https://codereview.chromium.org/2173413002/diff/20001/third_party/WebKit/Source/web/web.gypi#newcode263 third_party/WebKit/Source/web/web.gypi:263: 'tests/ListenerLeakTest.cpp', The order was wrong in the original gypi.
4 years, 5 months ago (2016-07-25 07:16:18 UTC) #11
esprehn
Perfect, thanks so much for adding a test! :D Hopefully using SimTest we can add ...
4 years, 5 months ago (2016-07-25 07:28:12 UTC) #12
esprehn
lgtm
4 years, 5 months ago (2016-07-25 07:28:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2173413002/20001
4 years, 5 months ago (2016-07-25 07:55:41 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-25 09:39:44 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 09:42:25 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d90f310e3bdfc51391a7c34d1982c8f23845090
Cr-Commit-Position: refs/heads/master@{#407439}

Powered by Google App Engine
This is Rietveld 408576698