Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a
possibility that a link element moved from a document tree to a disconnected
non-shadow tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141
Committed: https://crrev.com/9461cb39b01538d866e99df243fbe5dc1a802290
Cr-Commit-Position: refs/heads/master@{#407398}

[hayato, 2016-07-22 09:58:56]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 09:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-22 10:00:10]

Description was changed from

==========
Fix the condition in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not correct.
The right approach is to check "in a document tree".

BUG=630141
==========

to

==========
Fix the condition in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here.

BUG=630141
==========

[hayato, 2016-07-22 10:04:09]

Description was changed from

==========
Fix the condition in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here.

BUG=630141
==========

to

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a a disconnected
tree.

BUG=630141
==========

[hayato, 2016-07-22 10:05:15]

Description was changed from

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a a disconnected
tree.

BUG=630141
==========

to

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a a disconnected
tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141
==========

[hayato, 2016-07-22 10:05:48]

Description was changed from

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a a disconnected
tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141
==========

to

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a disconnected 
non-shadow tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141
==========

[hayato, 2016-07-22 10:06:33]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-07-22 10:06:34]

PTAL

[kochi, 2016-07-22 10:57:11]

LGTM

Did we have any real test failure or can we have test case
to reproduce the condition (move link element to detached
shadow tree)?

[commit-bot: I haz the power, 2016-07-22 11:43:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 11:43:32]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hayato, 2016-07-25 01:16:38]

On 2016/07/22 at 10:57:11, kochi wrote:
> LGTM
> 
> Did we have any real test failure or can we have test case
> to reproduce the condition (move link element to detached
> shadow tree)?

No, I did not have a real test failure, but it could fail.

This is an attempt to fix an unrelated issue separately, before supporting the
630141,
so that one CL will not have a lot of responsibilities.

[hayato, 2016-07-25 01:16:43]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-07-25 01:16:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 02:29:13]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-25 02:31:08]

Description was changed from

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a 
possibility that a link element moved from a document tree to a disconnected 
non-shadow tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141
==========

to

==========
Fix the condition to call removePandingSheet() in LinkStyle::setCSSStyleSheet

It looks that https://codereview.chromium.org/1285413002 is not a correct fix.
The right approach is to check "in a document tree" here because there is a
possibility that a link element moved from a document tree to a disconnected
non-shadow tree.

TEST=None. It might be difficult to write a meaningful non-flaky test.
BUG=630141

Committed: https://crrev.com/9461cb39b01538d866e99df243fbe5dc1a802290
Cr-Commit-Position: refs/heads/master@{#407398}
==========

[commit-bot: I haz the power, 2016-07-25 02:31:09]

Patchset 1 (id:??) landed as
https://crrev.com/9461cb39b01538d866e99df243fbe5dc1a802290
Cr-Commit-Position: refs/heads/master@{#407398}

[esprehn, 2016-07-25 02:36:58]

You can write a non flaky SimTest since you can control the network responses
come back. Please add a test. :)

(See ex. DocumentLoadingRenderingTest)

[hayato, 2016-07-25 02:41:19]

On 2016/07/25 at 02:36:58, esprehn wrote:
> You can write a non flaky SimTest since you can control the network responses
come back. Please add a test. :)
> 
> (See ex. DocumentLoadingRenderingTest)

Thanks. But let me add a test in another CL for BUG 630141.
This CL's change was already replaced there, and I had to rewrite the test
again. :) Sorry for the laziness.