ui/views/widget/desktop_aura/desktop_native_widget_aura.h - Issue 2173033002: Make various views SetShape() methods take an unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/widget/desktop_aura/desktop_native_widget_aura.h

Issue 2173033002: Make various views SetShape() methods take an unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/widget/desktop_aura/desktop_native_widget_aura.h

diff --git a/ui/views/widget/desktop_aura/desktop_native_widget_aura.h b/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

index 93222976dd99061d3efa61147b7485f768019e04..4ed4955f6ba3229ccf77be7b62a869ef4c5db18d 100644

--- a/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

+++ b/ui/views/widget/desktop_aura/desktop_native_widget_aura.h

@@ -129,7 +129,7 @@ class VIEWS_EXPORT DesktopNativeWidgetAura

void StackAbove(gfx::NativeView native_view) override;

void StackAtTop() override;

void StackBelow(gfx::NativeView native_view) override;

- void SetShape(SkRegion* shape) override;

+ void SetShape(std::unique_ptr<SkRegion> shape) override;

void Close() override;

void CloseNow() override;

void Show() override;

« no previous file with comments | « ui/views/mus/native_widget_mus.cc ('k') | ui/views/widget/desktop_aura/desktop_native_widget_aura.cc » ('j') | no next file with comments »