Invalidate results, which compound results of other targets.

Invalidate results, which compound results of other targets.

These results might become invalid even if the source does not use
directly any of changed names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/351cbb5a9246bb25f81c1a8aa7bba9c69cec0eb5

[Paul Berry, 2016-07-22 17:04:57]

I don't really understand how the dependency tracking logic in the task model
works so I'm going to defer to Brian for this review.

[scheglov, 2016-07-27 17:50:20]

Brian, ping.

[Brian Wilkerson, 2016-07-27 18:47:37]

lgtm

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:672: if (deltaResult ==
DeltaResult.INVALIDATE_KEEP_DEPENDENCIES) {
Seem kind of strange to nest this. Why not make it an 'if-else' construct?

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/task/d...
File pkg/analyzer/lib/src/task/dart.dart (right):

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/task/d...
pkg/analyzer/lib/src/task/dart.dart:2728: descriptor == READY_LIBRARY_ELEMENT7)
{
I know we're doing this elsewhere as well, but it would be nice to not have
hard-coded lists of descriptors. Perhaps we should consider (in a separate CL)
adding some more state to descriptors to remove the need for this (in this case
a "isCompounding" attribute). But this observation doesn't need to stop this CL.

[scheglov, 2016-07-27 19:48:44]

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/contex...
File pkg/analyzer/lib/src/context/cache.dart (right):

https://codereview.chromium.org/2172973002/diff/1/pkg/analyzer/lib/src/contex...
pkg/analyzer/lib/src/context/cache.dart:672: if (deltaResult ==
DeltaResult.INVALIDATE_KEEP_DEPENDENCIES) {
On 2016/07/27 18:47:37, Brian Wilkerson wrote:
> Seem kind of strange to nest this. Why not make it an 'if-else' construct?

Done.

[scheglov, 2016-07-27 19:51:09]

Description was changed from

==========
Invalidate results, which compound results of other targets.

These results might become invalid even if the source does not use
directly any of changed names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Invalidate results, which compound results of other targets.

These results might become invalid even if the source does not use
directly any of changed names.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/351cbb5a9246bb25f81c1a8aa7bba9c69cec0eb5
==========

[scheglov, 2016-07-27 19:51:11]

Committed patchset #1 (id:1) manually as
351cbb5a9246bb25f81c1a8aa7bba9c69cec0eb5 (presubmit successful).