Invalidate results, which compound results of other targets.

pkg/analyzer/lib/src/task/dart.dart

Index: pkg/analyzer/lib/src/task/dart.dart
diff --git a/pkg/analyzer/lib/src/task/dart.dart b/pkg/analyzer/lib/src/task/dart.dart
index 893e7285115990c5b7ccd43846b0aae561dc4e66..0e236bf2194a286ecb213c474367508903bd435e 100644
--- a/pkg/analyzer/lib/src/task/dart.dart
+++ b/pkg/analyzer/lib/src/task/dart.dart
@@ -2722,6 +2722,12 @@ class DartDelta extends Delta {
     if (hasDirectiveChange) {
       return DeltaResult.INVALIDATE;
     }
+    // Always invalidate compounding results.
+    if (descriptor == LIBRARY_ELEMENT4 ||
+        descriptor == READY_LIBRARY_ELEMENT6 ||
+        descriptor == READY_LIBRARY_ELEMENT7) {

[Brian Wilkerson, 2016/07/27 18:47:37]

I know we're doing this elsewhere as well, but it would be nice to not have
hard-coded lists of descriptors. Perhaps we should consider (in a separate CL)
adding some more state to descriptors to remove the need for this (in this case
a "isCompounding" attribute). But this observation doesn't need to stop this CL.

+      return DeltaResult.INVALIDATE_KEEP_DEPENDENCIES;
+    }
     // Prepare target source.
     Source targetUnit = target.source;
     Source targetLibrary = target.librarySource;
@@ -2764,7 +2770,7 @@ class DartDelta extends Delta {
         return DeltaResult.INVALIDATE;
       }
       if (librariesWithAllValidResults.contains(targetLibrary)) {
-        return DeltaResult.STOP;
+        return DeltaResult.KEEP_CONTINUE;
       }
       // The library is almost, but not completely valid.
       // Some error results are invalid.
@@ -2789,7 +2795,7 @@ class DartDelta extends Delta {
         return DeltaResult.KEEP_CONTINUE;
       }
       librariesWithAllValidResults.add(targetLibrary);
-      return DeltaResult.STOP;
+      return DeltaResult.KEEP_CONTINUE;
     }
     // We don't know what to do with the given target, invalidate it.
     return DeltaResult.INVALIDATE;