Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2172813002: Tidy up JS_Value.h (Closed)

Created:
4 years, 5 months ago by Tom Sepez
Modified:
4 years, 5 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Tidy up JS_Value.h Use ToV8Object() instead of CJS_Value cast operator. Add some missing consts / explicits. Move code into empty namespace. Committed: https://pdfium.googlesource.com/pdfium/+/fbf52c2231bd148bcf1fcd6ac1e6a5ed5e311b8c

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : rebse #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -116 lines) Patch
M fpdfsdk/javascript/JS_Define.h View 2 chunks +2 lines, -2 lines 0 comments Download
M fpdfsdk/javascript/JS_Value.h View 1 2 4 chunks +31 lines, -38 lines 1 comment Download
M fpdfsdk/javascript/JS_Value.cpp View 1 2 13 chunks +60 lines, -76 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Tom Sepez
dsinclair, remnants.
4 years, 5 months ago (2016-07-25 17:23:34 UTC) #4
Tom Sepez
https://codereview.chromium.org/2172813002/diff/40001/fpdfsdk/javascript/JS_Value.h File fpdfsdk/javascript/JS_Value.h (right): https://codereview.chromium.org/2172813002/diff/40001/fpdfsdk/javascript/JS_Value.h#newcode145 fpdfsdk/javascript/JS_Value.h:145: mutable v8::Local<v8::Array> m_pArray; Note: mutable because some const get ...
4 years, 5 months ago (2016-07-25 17:24:46 UTC) #5
dsinclair
lgtm
4 years, 5 months ago (2016-07-25 18:05:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172813002/40001
4 years, 5 months ago (2016-07-25 18:05:32 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 18:17:14 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/fbf52c2231bd148bcf1fcd6ac1e6a5ed5e31...

Powered by Google App Engine
This is Rietveld 408576698