Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: fpdfsdk/javascript/JS_Define.h

Issue 2172813002: Tidy up JS_Value.h (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: rebse Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Value.h » ('j') | fpdfsdk/javascript/JS_Value.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: fpdfsdk/javascript/JS_Define.h
diff --git a/fpdfsdk/javascript/JS_Define.h b/fpdfsdk/javascript/JS_Define.h
index 6aa1dec768e89cf77d4e37c2c2a8c8778663bee1..e120758c60f91bf666846da03cbbf7cdb2ae354a 100644
--- a/fpdfsdk/javascript/JS_Define.h
+++ b/fpdfsdk/javascript/JS_Define.h
@@ -92,7 +92,7 @@ void JSPropGetter(const char* prop_name_string,
sError));
return;
}
- info.GetReturnValue().Set((v8::Local<v8::Value>)value);
+ info.GetReturnValue().Set(value.ToV8Value());
}
template <class C,
@@ -383,7 +383,7 @@ void JSSpecialPropGet(const char* class_name,
FXJS_Error(isolate, JSFormatErrorString(class_name, "GetProperty", sError));
return;
}
- info.GetReturnValue().Set((v8::Local<v8::Value>)value);
+ info.GetReturnValue().Set(value.ToV8Value());
}
template <class Alt>
« no previous file with comments | « no previous file | fpdfsdk/javascript/JS_Value.h » ('j') | fpdfsdk/javascript/JS_Value.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698