third_party/WebKit/Source/core/layout/LayoutVideo.cpp - Issue 2172503002: Fix subpixel accumulation for composited content layers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

Issue 2172503002: Fix subpixel accumulation for composited content layers Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add test expectation Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutVideo.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

index 2a9483ee9b58da882a0e22df4f0b4b5e07d0c19c..6080ec44a5e217fce8f0bf1ff75a8b71c4fdef04 100644

--- a/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutVideo.cpp

@@ -122,13 +122,13 @@ void LayoutVideo::imageChanged(WrappedImagePtr newImage, const IntRect* rect)

updateIntrinsicSize();

}

-IntRect LayoutVideo::videoBox() const

+LayoutRect LayoutVideo::videoBox() const

{

const LayoutSize* overriddenIntrinsicSize = nullptr;

if (videoElement()->shouldDisplayPosterImage())

overriddenIntrinsicSize = &m_cachedImageSize;

- return pixelSnappedIntRect(replacedContentRect(overriddenIntrinsicSize));

+ return replacedContentRect(overriddenIntrinsicSize);

}

bool LayoutVideo::shouldDisplayVideo() const