Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp

Issue 2172503002: Fix subpixel accumulation for composited content layers Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add test expectation Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp b/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp
index 0ec64a427a78aa8ad385bae147f9408a644ac975..1d459084ac90ace8a6569d6ed531774786f4fe22 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTextTrackContainer.cpp
@@ -59,12 +59,9 @@ bool LayoutTextTrackContainer::updateSizes(const LayoutVideo& videoLayoutObject)
// for lack of per-spec vh/vw support) but the whole media element is used
// for cue rendering. This is inconsistent. See also the somewhat related
// spec bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=28105
- IntSize videoSize = videoLayoutObject.videoBox().size();
chrishtr 2016/07/21 18:02:31 Why the changes here? videoBox() has integer size.
- if (m_videoSize == videoSize)
- return false;
- m_videoSize = videoSize;
+ LayoutSize videoSize = videoLayoutObject.videoBox().size();
- float smallestDimension = std::min(m_videoSize.height(), m_videoSize.width());
+ float smallestDimension = std::min(videoSize.height(), videoSize.width()).toFloat();
float fontSize = smallestDimension * 0.05f;
if (m_fontSize == fontSize)

Powered by Google App Engine
This is Rietveld 408576698