Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 217243004: Remove no longer needed instrumentation in RenderTextWin. (Closed)

Created:
6 years, 9 months ago by Alexei Svitkine (slow)
Modified:
6 years, 8 months ago
Reviewers:
msw
CC:
chromium-reviews
Visibility:
Public.

Description

Remove no longer needed instrumentation in RenderTextWin. The underlying bug has been fixed (and was not in RenderText). BUG=348103 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260385

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ui/gfx/render_text_win.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Alexei Svitkine (slow)
6 years, 9 months ago (2014-03-28 20:44:18 UTC) #1
msw
lgtm, but posting more info on the bug would help. Was this ever hit? No, ...
6 years, 9 months ago (2014-03-28 21:06:15 UTC) #2
Alexei Svitkine (slow)
On 2014/03/28 21:06:15, msw wrote: > lgtm, but posting more info on the bug would ...
6 years, 9 months ago (2014-03-28 22:25:13 UTC) #3
Alexei Svitkine (slow)
On 2014/03/28 22:25:13, Alexei Svitkine wrote: > On 2014/03/28 21:06:15, msw wrote: > > lgtm, ...
6 years, 9 months ago (2014-03-28 22:26:04 UTC) #4
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 9 months ago (2014-03-28 22:26:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
6 years, 9 months ago (2014-03-28 22:26:58 UTC) #6
Alexei Svitkine (slow)
(And this was never hit because it landed in as r254253 whereas the fix for ...
6 years, 9 months ago (2014-03-28 22:27:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 03:24:15 UTC) #8
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 8 months ago (2014-03-29 03:24:15 UTC) #9
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-03-29 04:45:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
6 years, 8 months ago (2014-03-29 04:46:04 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-03-29 06:31:02 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-03-29 06:31:02 UTC) #13
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 8 months ago (2014-03-29 12:29:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
6 years, 8 months ago (2014-03-29 12:30:28 UTC) #15
commit-bot: I haz the power
6 years, 8 months ago (2014-03-29 17:47:29 UTC) #16
Message was sent while issue was closed.
Change committed as 260385

Powered by Google App Engine
This is Rietveld 408576698