|
|
Chromium Code Reviews|
Created:
6 years, 9 months ago by Alexei Svitkine (slow) Modified:
6 years, 8 months ago Reviewers:
msw CC:
chromium-reviews Base URL:
svn://svn.chromium.org/chrome/trunk/src/ Visibility:
Public. |
DescriptionRemove no longer needed instrumentation in RenderTextWin.
The underlying bug has been fixed (and was not in RenderText).
BUG=348103
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260385
Patch Set 1 #
Messages
Total messages: 16 (0 generated)
lgtm, but posting more info on the bug would help. Was this ever hit? No, afaict. What are the latest thoughts?
On 2014/03/28 21:06:15, msw wrote: > lgtm, but posting more info on the bug would help. > Was this ever hit? No, afaict. What are the latest thoughts? The bug was tracked down as having been fixed by: https://codereview.chromium.org/182273003/ (It was introduced by https://src.chromium.org/viewvc/chrome?revision=251408&view=revision.)
On 2014/03/28 22:25:13, Alexei Svitkine wrote: > On 2014/03/28 21:06:15, msw wrote: > > lgtm, but posting more info on the bug would help. > > Was this ever hit? No, afaict. What are the latest thoughts? > > The bug was tracked down as having been fixed by: > > https://codereview.chromium.org/182273003/ > > (It was introduced by > https://src.chromium.org/viewvc/chrome?revision=251408&view=revision.) (There are more details in some offline threads.)
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
(And this was never hit because it landed in as r254253 whereas the fix for the issue landed before it in r253740.)
The CQ bit was unchecked by commit-bot@chromium.org
Commit queue rejected this change because the description was changed between the time the change entered the commit queue and the time it was ready to commit. You can safely check the commit box again.
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
The CQ bit was checked by asvitkine@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/217243004/1
Message was sent while issue was closed.
Change committed as 260385 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
