Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: ui/gfx/render_text_win.cc

Issue 217243004: Remove no longer needed instrumentation in RenderTextWin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/render_text_win.cc
===================================================================
--- ui/gfx/render_text_win.cc (revision 260135)
+++ ui/gfx/render_text_win.cc (working copy)
@@ -1009,13 +1009,6 @@
if (run->glyph_count > 0) {
run->advance_widths.reset(new int[run->glyph_count]);
- // TODO(asvitkine): Temporary instrumentation to debug a double-free
- // crash where we're seeing these two being equal inexplicably. Hitting
- // this implies that the malloc book-keeping is corrupt and it returned
- // the same pointer for two different allocs, which we can debug further.
- // http://crbug.com/348103
- CHECK_NE(static_cast<void*>(run->logical_clusters.get()),
- static_cast<void*>(run->advance_widths.get()));
run->offsets.reset(new GOFFSET[run->glyph_count]);
hr = ScriptPlace(cached_hdc_,
&run->script_cache,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698