Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 217233004: Revert of Remove ExtensionService Garbage-Collecting methods. (Closed)

Created:
6 years, 9 months ago by DaleCurtis
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Remove ExtensionService Garbage-Collecting methods. (https://codereview.chromium.org/204983020/) Reason for revert: Launch the browser and just wait a bit, eventually it crashes with: [6912:6955:0328/131903:FATAL:weak_ptr.cc(26)] Check failed: sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked on the same sequenced thread. Commenting out that check then gets you to: [12009:12077:0328/133048:FATAL:extension_garbage_collector.cc(232)] Check failed: content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE). Reverting the patch fixes the issue. Original issue's description: > Remove ExtensionService Garbage-Collecting methods. > > Make a new class, ExtensionGarbageCollector, which performs: > - ExtensionService::GarbageCollectExtensions(), > - extension_file_util::GarbageCollectExtensions() (the file-thread impl of > ExtensionService::GarbageCollectExtensions()), > - ExtensionService::GarbageCollectIsolatedStorage() > > BUG=351891 > TBR=rkc@chromium.org (for c/b/chromeos/kiosk_mode - no functional changes, but the TODO has moved from ExtensionService to ExtensionGarbageCollector). > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260207 TBR=yoz@chromium.org,jyasskin@chromium.org,rkc@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=351891 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260265

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+374 lines, -562 lines) Patch
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc View 3 chunks +2 lines, -3 lines 0 comments Download
D chrome/browser/extensions/extension_garbage_collector.h View 1 chunk +0 lines, -88 lines 0 comments Download
D chrome/browser/extensions/extension_garbage_collector.cc View 1 chunk +0 lines, -249 lines 0 comments Download
D chrome/browser/extensions/extension_garbage_collector_unittest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M chrome/browser/extensions/extension_service.h View 8 chunks +32 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 8 chunks +103 lines, -9 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +112 lines, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.h View 3 chunks +17 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util.cc View 5 chunks +83 lines, -3 lines 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +13 lines, -1 line 0 comments Download
M extensions/common/one_shot_event.h View 3 chunks +2 lines, -13 lines 0 comments Download
M extensions/common/one_shot_event.cc View 4 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
DaleCurtis
Created Revert of Remove ExtensionService Garbage-Collecting methods.
6 years, 9 months ago (2014-03-28 20:40:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/217233004/1
6 years, 9 months ago (2014-03-28 20:41:13 UTC) #2
commit-bot: I haz the power
Change committed as 260265
6 years, 9 months ago (2014-03-28 20:43:42 UTC) #3
DaleCurtis
6 years, 9 months ago (2014-03-28 20:46:09 UTC) #4
Message was sent while issue was closed.
If waiting doesn't trigger the crash, try loading this video:

http://commondatastorage.googleapis.com/dalecurtis-shared/buck2.mp4

Powered by Google App Engine
This is Rietveld 408576698