Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Side by Side Diff: chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.cc

Issue 217233004: Revert of Remove ExtensionService Garbage-Collecting methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_garbage_collector.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h" 5 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_screensaver.h"
6 6
7 #include "ash/screensaver/screensaver_view.h" 7 #include "ash/screensaver/screensaver_view.h"
8 #include "ash/shell.h" 8 #include "ash/shell.h"
9 #include "ash/wm/user_activity_detector.h" 9 #include "ash/wm/user_activity_detector.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
11 #include "base/callback.h" 11 #include "base/callback.h"
12 #include "base/lazy_instance.h" 12 #include "base/lazy_instance.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "chrome/browser/browser_process.h" 14 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/chrome_notification_types.h" 15 #include "chrome/browser/chrome_notification_types.h"
16 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h" 16 #include "chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.h"
17 #include "chrome/browser/chromeos/login/existing_user_controller.h" 17 #include "chrome/browser/chromeos/login/existing_user_controller.h"
18 #include "chrome/browser/chromeos/login/login_display_host_impl.h" 18 #include "chrome/browser/chromeos/login/login_display_host_impl.h"
19 #include "chrome/browser/chromeos/policy/app_pack_updater.h" 19 #include "chrome/browser/chromeos/policy/app_pack_updater.h"
20 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h" 20 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
21 #include "chrome/browser/chromeos/profiles/profile_helper.h" 21 #include "chrome/browser/chromeos/profiles/profile_helper.h"
22 #include "chrome/browser/extensions/extension_garbage_collector.h"
23 #include "chrome/browser/extensions/extension_service.h" 22 #include "chrome/browser/extensions/extension_service.h"
24 #include "chrome/browser/extensions/sandboxed_unpacker.h" 23 #include "chrome/browser/extensions/sandboxed_unpacker.h"
25 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h" 24 #include "chrome/browser/ui/webui/chromeos/login/oobe_ui.h"
26 #include "chrome/common/extensions/extension_file_util.h" 25 #include "chrome/common/extensions/extension_file_util.h"
27 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h" 26 #include "chrome/common/extensions/manifest_handlers/app_launch_info.h"
28 #include "chromeos/login/login_state.h" 27 #include "chromeos/login/login_state.h"
29 #include "content/public/browser/browser_thread.h" 28 #include "content/public/browser/browser_thread.h"
30 #include "content/public/browser/notification_service.h" 29 #include "content/public/browser/notification_service.h"
31 #include "extensions/browser/extension_system.h" 30 #include "extensions/browser/extension_system.h"
32 #include "extensions/common/extension.h" 31 #include "extensions/common/extension.h"
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 102
104 void ScreensaverUnpackerClient::LoadScreensaverExtension( 103 void ScreensaverUnpackerClient::LoadScreensaverExtension(
105 const base::FilePath& extension_base_path, 104 const base::FilePath& extension_base_path,
106 const base::FilePath& screensaver_extension_path) { 105 const base::FilePath& screensaver_extension_path) {
107 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE)); 106 DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
108 107
109 ExtensionService* service = GetDefaultExtensionService(); 108 ExtensionService* service = GetDefaultExtensionService();
110 // TODO(rkc): This is a HACK, please remove this method from extension 109 // TODO(rkc): This is a HACK, please remove this method from extension
111 // service once this code is deprecated. See crbug.com/280363 110 // service once this code is deprecated. See crbug.com/280363
112 if (service) 111 if (service)
113 service->garbage_collector()->disable_garbage_collection(); 112 service->disable_garbage_collection();
114 113
115 std::string error; 114 std::string error;
116 scoped_refptr<Extension> screensaver_extension = 115 scoped_refptr<Extension> screensaver_extension =
117 extension_file_util::LoadExtension(screensaver_extension_path, 116 extension_file_util::LoadExtension(screensaver_extension_path,
118 extensions::Manifest::COMPONENT, 117 extensions::Manifest::COMPONENT,
119 Extension::NO_FLAGS, 118 Extension::NO_FLAGS,
120 &error); 119 &error);
121 if (!screensaver_extension.get()) { 120 if (!screensaver_extension.get()) {
122 LOG(ERROR) << "Could not load screensaver extension from: " 121 LOG(ERROR) << "Could not load screensaver extension from: "
123 << screensaver_extension_path.value() << " due to: " << error; 122 << screensaver_extension_path.value() << " due to: " << error;
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 // do anything (see crbug.com/288216). 170 // do anything (see crbug.com/288216).
172 if (!g_browser_process || g_browser_process->IsShuttingDown()) 171 if (!g_browser_process || g_browser_process->IsShuttingDown())
173 return; 172 return;
174 173
175 // If the extension was unpacked. 174 // If the extension was unpacked.
176 if (!extension_base_path_.empty()) { 175 if (!extension_base_path_.empty()) {
177 ExtensionService* service = GetDefaultExtensionService(); 176 ExtensionService* service = GetDefaultExtensionService();
178 // TODO(rkc): This is a HACK, please remove this method from extension 177 // TODO(rkc): This is a HACK, please remove this method from extension
179 // service once this code is deprecated. See crbug.com/280363 178 // service once this code is deprecated. See crbug.com/280363
180 if (service) 179 if (service)
181 service->garbage_collector()->enable_garbage_collection(); 180 service->enable_garbage_collection();
182 181
183 // Delete it. 182 // Delete it.
184 content::BrowserThread::PostTask( 183 content::BrowserThread::PostTask(
185 content::BrowserThread::FILE, 184 content::BrowserThread::FILE,
186 FROM_HERE, 185 FROM_HERE,
187 base::Bind( 186 base::Bind(
188 &extension_file_util::DeleteFile, extension_base_path_, true)); 187 &extension_file_util::DeleteFile, extension_base_path_, true));
189 } 188 }
190 189
191 // In case we're shutting down without ever triggering the active 190 // In case we're shutting down without ever triggering the active
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
300 299
301 g_kiosk_mode_screensaver = new KioskModeScreensaver(); 300 g_kiosk_mode_screensaver = new KioskModeScreensaver();
302 } 301 }
303 302
304 void ShutdownKioskModeScreensaver() { 303 void ShutdownKioskModeScreensaver() {
305 delete g_kiosk_mode_screensaver; 304 delete g_kiosk_mode_screensaver;
306 g_kiosk_mode_screensaver = NULL; 305 g_kiosk_mode_screensaver = NULL;
307 } 306 }
308 307
309 } // namespace chromeos 308 } // namespace chromeos
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_garbage_collector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698