[stubs] Call interface descriptors cleanup.

[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor is the only place that defines calling convention for a particular code stub.

Committed: https://crrev.com/13aa1d020333a45442b76848969cdce4f3e96aa8
Cr-Commit-Position: refs/heads/master@{#38059}

[Igor Sheludko, 2016-07-25 17:30:13]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-25 17:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-25 17:31:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-25 17:31:31]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9655)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9636)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9600)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/20169)

[Igor Sheludko, 2016-07-26 07:34:24]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-07-26 07:34:31]

Patchset #1 (id:20001) has been deleted

[Igor Sheludko, 2016-07-26 07:34:38]

Patchset #1 (id:40001) has been deleted

[Igor Sheludko, 2016-07-26 07:36:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 07:36:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 07:41:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 07:41:02]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/11191)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)

[Igor Sheludko, 2016-07-26 07:41:39]

Description was changed from

==========
WIP: Changing StoreIC args order and interface descriptors cleanup

BUG=
==========

to

==========
[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor
is the only place that defines calling convention for a particular code stub.
==========

[Igor Sheludko, 2016-07-26 08:08:59]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 08:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-26 08:12:05]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-07-26 08:14:51]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-07-26 08:14:52]

PTAL

[Igor Sheludko, 2016-07-26 09:58:20]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 09:58:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-07-26 09:59:48]

ishell@chromium.org changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[Igor Sheludko, 2016-07-26 09:59:48]

Ross, PTAL @ interpreter
Michi, PTAL @ compiler
Michael, PTAL @ all

[commit-bot: I haz the power, 2016-07-26 10:21:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 10:21:34]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-07-26 10:55:03]

LGTM, good cleanup. :)

https://codereview.chromium.org/2172223002/diff/100001/test/cctest/compiler/t...
File test/cctest/compiler/test-node.cc (right):

https://codereview.chromium.org/2172223002/diff/100001/test/cctest/compiler/t...
test/cctest/compiler/test-node.cc:323: TEST(InsertInputs) {
Nice test, thanks!

[rmcilroy, 2016-07-26 13:27:54]

Interpreter LGTM with a comment.

https://codereview.chromium.org/2172223002/diff/100001/src/interpreter/interp...
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/2172223002/diff/100001/src/interpreter/interp...
src/interpreter/interpreter.cc:387: typedef InterpreterAssembler::Arg Arg;
Please do this typedef once at the top of the file (along side the Variable and
Label typedefs).

[Michael Starzinger, 2016-07-26 13:45:47]

LGTM on compiler. I am not fully convinced of the reshuffling in
JSGenericLowering, but I don't have a better alternative at the moment.

[Igor Sheludko, 2016-07-26 14:30:31]

Thanks! Landing...

https://codereview.chromium.org/2172223002/diff/100001/src/interpreter/interp...
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/2172223002/diff/100001/src/interpreter/interp...
src/interpreter/interpreter.cc:387: typedef InterpreterAssembler::Arg Arg;
On 2016/07/26 13:27:53, rmcilroy wrote:
> Please do this typedef once at the top of the file (along side the Variable
and
> Label typedefs).

Done.

[Igor Sheludko, 2016-07-26 14:30:41]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-07-26 14:30:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org, rmcilroy@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2172223002/#ps120001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-07-26 14:30:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:56:10]

Description was changed from

==========
[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor
is the only place that defines calling convention for a particular code stub.
==========

to

==========
[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor
is the only place that defines calling convention for a particular code stub.
==========

[commit-bot: I haz the power, 2016-07-26 14:56:11]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-07-26 14:56:41]

Description was changed from

==========
[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor
is the only place that defines calling convention for a particular code stub.
==========

to

==========
[stubs] Call interface descriptors cleanup.

This is a first step towards a perfect world where a call interface descriptor
is the only place that defines calling convention for a particular code stub.

Committed: https://crrev.com/13aa1d020333a45442b76848969cdce4f3e96aa8
Cr-Commit-Position: refs/heads/master@{#38059}
==========

[commit-bot: I haz the power, 2016-07-26 14:56:42]

Patchset 3 (id:??) landed as
https://crrev.com/13aa1d020333a45442b76848969cdce4f3e96aa8
Cr-Commit-Position: refs/heads/master@{#38059}