[stubs] Call interface descriptors cleanup.

test/cctest/compiler/test-node.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <functional>
 
 #include "src/compiler/graph.h"
 #include "src/compiler/node.h"
 #include "src/compiler/operator.h"
 #include "test/cctest/cctest.h"
@@ skipping 302 matching lines @@
   n3->AppendInput(graph.zone(), n4);
 
   CHECK_INPUTS(n3, n0, n1, n2, n4, n4);
   CHECK_USES(n4, n3, n3);
 
   Node* n5 = graph.NewNode(&dummy_operator1, n4);
 
   CHECK_USES(n4, n3, n3, n5);
 }
 
+TEST(InsertInputs) {

[mvstanton, 2016/07/26 10:55:03]

Nice test, thanks!

+  base::AccountingAllocator allocator;
+  Zone zone(&allocator);
+  Graph graph(&zone);
+
+  Node* n0 = graph.NewNode(&dummy_operator0);
+  Node* n1 = graph.NewNode(&dummy_operator1, n0);
+  Node* n2 = graph.NewNode(&dummy_operator1, n0);
+
+  {
+    Node* node = graph.NewNode(&dummy_operator1, n0);
+    node->InsertInputs(graph.zone(), 0, 1);
+    node->ReplaceInput(0, n1);
+    CHECK_INPUTS(node, n1, n0);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator1, n0);
+    node->InsertInputs(graph.zone(), 0, 2);
+    node->ReplaceInput(0, node);
+    node->ReplaceInput(1, n2);
+    CHECK_INPUTS(node, node, n2, n0);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 0, 1);
+    node->ReplaceInput(0, node);
+    CHECK_INPUTS(node, node, n0, n1, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 1, 1);
+    node->ReplaceInput(1, node);
+    CHECK_INPUTS(node, n0, node, n1, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 2, 1);
+    node->ReplaceInput(2, node);
+    CHECK_INPUTS(node, n0, n1, node, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 2, 1);
+    node->ReplaceInput(2, node);
+    CHECK_INPUTS(node, n0, n1, node, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 0, 4);
+    node->ReplaceInput(0, node);
+    node->ReplaceInput(1, node);
+    node->ReplaceInput(2, node);
+    node->ReplaceInput(3, node);
+    CHECK_INPUTS(node, node, node, node, node, n0, n1, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 1, 4);
+    node->ReplaceInput(1, node);
+    node->ReplaceInput(2, node);
+    node->ReplaceInput(3, node);
+    node->ReplaceInput(4, node);
+    CHECK_INPUTS(node, n0, node, node, node, node, n1, n2);
+  }
+  {
+    Node* node = graph.NewNode(&dummy_operator3, n0, n1, n2);
+    node->InsertInputs(graph.zone(), 2, 4);
+    node->ReplaceInput(2, node);
+    node->ReplaceInput(3, node);
+    node->ReplaceInput(4, node);
+    node->ReplaceInput(5, node);
+    CHECK_INPUTS(node, n0, n1, node, node, node, node, n2);
+  }
+}
 
 TEST(RemoveInput) {
   base::AccountingAllocator allocator;
   Zone zone(&allocator);
   Graph graph(&zone);
 
   Node* n0 = graph.NewNode(&dummy_operator0);
   Node* n1 = graph.NewNode(&dummy_operator1, n0);
   Node* n2 = graph.NewNode(&dummy_operator2, n0, n1);
 
@@ skipping 464 matching lines @@
       if (j >= i) CHECK_USES(nodes[j], NONE);
     }
 
     CHECK_USES(last, NONE);
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8