Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2172153004: Revert of [system health] Make mobile washington post story more robust. (Closed)

Created:
4 years, 5 months ago by petrcermak
Modified:
4 years, 5 months ago
Reviewers:
ulan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [system health] Make mobile washington post story more robust. (patchset #4 id:60001 of https://codereview.chromium.org/2171713003/ ) Reason for revert: It broke Android perf bots. Original issue's description: > [system health] Make mobile washington post story more robust. > > This patch makes sure that we wait for either the "Close" or > the "Send link to phone" button after loading the document. > > BUG=629983 > > Committed: https://crrev.com/10766908401f0dd9631b670aa252c33473c41f67 > Cr-Commit-Position: refs/heads/master@{#406816} TBR=ulan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=629983 Committed: https://crrev.com/cf0294eaeb75f88766ef6513c4701d34af353507 Cr-Commit-Position: refs/heads/master@{#407136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 chunk +2 lines, -5 lines 0 comments Download
M tools/perf/page_sets/system_health/loading_stories.py View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
petrcermak
Created Revert of [system health] Make mobile washington post story more robust.
4 years, 5 months ago (2016-07-22 11:25:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2172153004/1
4 years, 5 months ago (2016-07-22 11:26:12 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 12:12:41 UTC) #4
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 12:13:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf0294eaeb75f88766ef6513c4701d34af353507
Cr-Commit-Position: refs/heads/master@{#407136}

Powered by Google App Engine
This is Rietveld 408576698