Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: tools/perf/page_sets/system_health/loading_stories.py

Issue 2172153004: Revert of [system health] Make mobile washington post story more robust. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/system_health/browsing_stories.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from page_sets.system_health import platforms 5 from page_sets.system_health import platforms
6 from page_sets.system_health import system_health_story 6 from page_sets.system_health import system_health_story
7 7
8 from page_sets.login_helpers import dropbox_login 8 from page_sets.login_helpers import dropbox_login
9 from page_sets.login_helpers import google_login 9 from page_sets.login_helpers import google_login
10 10
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 # always fails to completely load due to 171 # always fails to completely load due to
172 # https://github.com/chromium/web-page-replay/issues/74. 172 # https://github.com/chromium/web-page-replay/issues/74.
173 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY 173 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
174 174
175 175
176 class LoadWashingtonPostMobileStory(_LoadingStory): 176 class LoadWashingtonPostMobileStory(_LoadingStory):
177 NAME = 'load:news:washingtonpost' 177 NAME = 'load:news:washingtonpost'
178 URL = 'https://www.washingtonpost.com/pwa' 178 URL = 'https://www.washingtonpost.com/pwa'
179 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY 179 SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
180 _CLOSE_BUTTON_SELECTOR = '.close' 180 _CLOSE_BUTTON_SELECTOR = '.close'
181 _MAIL_BUTTON_SELECTOR = '.mailBlock'
182 181
183 def _DidLoadDocument(self, action_runner): 182 def _DidLoadDocument(self, action_runner):
184 # Close the popup window. On Nexus 9 (and probably other tables) the popup 183 # Close the popup window. On Nexus 9 (and probably other tables) the popup
185 # window does not have a "Close" button, instead it has only a "Send link 184 # window does not have a "Close" button, instead it has only a "Send link
186 # to phone" button. So on tablets we run with the popup window open. The 185 # to phone" button. So on tablets we run with the popup window open. The
187 # popup is transparent, so this is mostly an aesthetical issue. 186 # popup is transparent, so this is mostly an aesthetical issue.
188 action_runner.WaitForElement(selector="%s, %s" % 187 has_button = action_runner.EvaluateJavaScript(
189 (self._CLOSE_BUTTON_SELECTOR, self._MAIL_BUTTON_SELECTOR))
190 has_close_button = action_runner.EvaluateJavaScript(
191 '!!document.querySelector("%s")' % self._CLOSE_BUTTON_SELECTOR) 188 '!!document.querySelector("%s")' % self._CLOSE_BUTTON_SELECTOR)
192 if has_close_button: 189 if has_button:
193 action_runner.ClickElement(selector=self._CLOSE_BUTTON_SELECTOR) 190 action_runner.ClickElement(selector=self._CLOSE_BUTTON_SELECTOR)
194 191
195 192
196 class LoadWikipediaStory(_LoadingStory): 193 class LoadWikipediaStory(_LoadingStory):
197 NAME = 'load:news:wikipedia' 194 NAME = 'load:news:wikipedia'
198 URL = 'https://en.wikipedia.org/wiki/Science' 195 URL = 'https://en.wikipedia.org/wiki/Science'
199 196
200 197
201 ################################################################################ 198 ################################################################################
202 # Audio and video. 199 # Audio and video.
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
372 URL = 'http://www.miniclip.com/games/en/' 369 URL = 'http://www.miniclip.com/games/en/'
373 # Desktop only (requires Flash). 370 # Desktop only (requires Flash).
374 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY 371 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
375 372
376 373
377 class LoadAlphabettyStory(_LoadingStory): 374 class LoadAlphabettyStory(_LoadingStory):
378 NAME = 'load:games:alphabetty' 375 NAME = 'load:games:alphabetty'
379 URL = 'https://king.com/play/alphabetty' 376 URL = 'https://king.com/play/alphabetty'
380 # Desktop only (requires Flash). 377 # Desktop only (requires Flash).
381 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY 378 SUPPORTED_PLATFORMS = platforms.DESKTOP_ONLY
OLDNEW
« no previous file with comments | « tools/perf/page_sets/system_health/browsing_stories.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698