Fix a crash caused by changing dir attribute of a slot element

Fix a crash caused by changing dir attribute of a slot element

HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this)
unconditionally. Since Blink does not support "slots in a flat tree", we
should return early here for a slot element.

BUG=627385
Committed: https://crrev.com/c75de11273c24c2a26738c5298074dac079b1016
Cr-Commit-Position: refs/heads/master@{#407108}

[hayato, 2016-07-22 06:04:19]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 06:04:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-07-22 06:07:12]

Description was changed from

==========
Fix a crash caused by changing dir attribute of a slot element

HTMLElement::

BUG==627385
==========

to

==========
Fix a crash caused by changing dir attribute of a slot element

HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this)
unconditionally. Since Blink does not support "slots in a flat tree", we
should return early here for a slot element.

BUG=627385
==========

[hayato, 2016-07-22 06:07:53]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-07-22 06:07:54]

PTAL

[commit-bot: I haz the power, 2016-07-22 07:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 07:15:23]

Dry run: This issue passed the CQ dry run.

[kochi, 2016-07-22 07:41:33]

lgtm

https://codereview.chromium.org/2172133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/2172133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLElement.cpp:781: return;
nit: The comment above and these 2 lines are not related, maybe swap
778-779 and 780-781?

[hayato, 2016-07-22 09:09:10]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:09:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:12:52]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 09:14:15]

Description was changed from

==========
Fix a crash caused by changing dir attribute of a slot element

HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this)
unconditionally. Since Blink does not support "slots in a flat tree", we
should return early here for a slot element.

BUG=627385
==========

to

==========
Fix a crash caused by changing dir attribute of a slot element

HTMLElement::dirAttributeChaged() calls FlatTreeTraversal::parent(*this)
unconditionally. Since Blink does not support "slots in a flat tree", we
should return early here for a slot element.

BUG=627385

Committed: https://crrev.com/c75de11273c24c2a26738c5298074dac079b1016
Cr-Commit-Position: refs/heads/master@{#407108}
==========

[commit-bot: I haz the power, 2016-07-22 09:14:16]

Patchset 1 (id:??) landed as
https://crrev.com/c75de11273c24c2a26738c5298074dac079b1016
Cr-Commit-Position: refs/heads/master@{#407108}

[hayato, 2016-07-22 09:59:36]

https://codereview.chromium.org/2172133002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/html/HTMLElement.cpp (right):

https://codereview.chromium.org/2172133002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/html/HTMLElement.cpp:781: return;
On 2016/07/22 at 07:41:33, kochi wrote:
> nit: The comment above and these 2 lines are not related, maybe swap
> 778-779 and 780-781?

Ah. Thanks, but I did not think so. I thought that this comment is applied to
all of this function.
Let me leave this as is.