third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html - Issue 2172133002: Fix a crash caused by changing dir attribute of a slot element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html

Issue 2172133002: Fix a crash caused by changing dir attribute of a slot element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html

diff --git a/third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html b/third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html

new file mode 100644

index 0000000000000000000000000000000000000000..a3c3f2c7a53662b7bf967aeeb8506d85d4f506b1

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/shadow-dom/crashes/slot-dir-attribute-crash.html

@@ -0,0 +1,11 @@

+<!DOCTYPE html>

+<script src='../../resources/testharness.js'></script>

+<script src='../../resources/testharnessreport.js'></script>

+<script>

+test(() => {

+ let slot = document.createElement("slot");

+ // This could cause crash. See crbug.com/627385

+ slot.setAttribute("dir", "auto");

+ assert_true(true, 'This test must run without crash.');

+}, "HTMLSlotElement's dir attribute should not be used until Blink supports slots in a flat tree.");

+</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('j') | third_party/WebKit/Source/core/html/HTMLElement.cpp » ('J')