cc: Compute transform to target using effect id.

cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8c62ff0808e13c426c1df30b809c3d406898a226
Cr-Commit-Position: refs/heads/master@{#407282}

[jaydasika, 2016-07-22 00:03:50]

Description was changed from

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=
==========

to

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-07-22 00:07:31]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:07:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jaydasika, 2016-07-22 00:08:22]

Description was changed from

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-07-22 00:08:53]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-07-22 00:08:54]

PTAL

[commit-bot: I haz the power, 2016-07-22 00:21:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 00:21:26]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[jaydasika, 2016-07-22 00:38:31]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 00:39:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 01:35:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:35:50]

Dry run: Try jobs failed on following builders:
  linux_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/8...)

[ajuma, 2016-07-22 13:45:38]

https://codereview.chromium.org/2172003002/diff/10005/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2172003002/diff/10005/cc/trees/property_tree....
cc/trees/property_tree.cc:1895: transform_id, effect_node->transform_id,
transform);
Do we also need to handle the case where the two transform nodes don't have an
ancestor-descendant relationship? See
https://cs.chromium.org/chromium/src/cc/trees/property_tree.cc?rcl=0&l=260 for
an example.

[jaydasika, 2016-07-22 15:59:52]

https://codereview.chromium.org/2172003002/diff/10005/cc/trees/property_tree.cc
File cc/trees/property_tree.cc (right):

https://codereview.chromium.org/2172003002/diff/10005/cc/trees/property_tree....
cc/trees/property_tree.cc:1895: transform_id, effect_node->transform_id,
transform);
On 2016/07/22 13:45:38, ajuma wrote:
> Do we also need to handle the case where the two transform nodes don't have an
> ancestor-descendant relationship? See
> https://cs.chromium.org/chromium/src/cc/trees/property_tree.cc?rcl=0&l=260 for
> an example.

This function calls CombineTransforms(/Inverses)Between which handles it.

[jaydasika, 2016-07-22 18:49:23]

fixed blink platform unittest failures

[jaydasika, 2016-07-22 18:49:32]

The CQ bit was checked by jaydasika@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 18:50:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ajuma, 2016-07-22 19:03:38]

Thanks, lgtm

[commit-bot: I haz the power, 2016-07-22 20:43:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 20:43:24]

Dry run: This issue passed the CQ dry run.

[jaydasika, 2016-07-22 22:21:12]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-07-22 22:21:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 22:25:53]

Description was changed from

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-07-22 22:25:54]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-07-22 22:28:16]

Description was changed from

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
==========

to

==========
cc: Compute transform to target using effect id.

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Committed: https://crrev.com/8c62ff0808e13c426c1df30b809c3d406898a226
Cr-Commit-Position: refs/heads/master@{#407282}
==========

[commit-bot: I haz the power, 2016-07-22 22:28:18]

Patchset 3 (id:??) landed as
https://crrev.com/8c62ff0808e13c426c1df30b809c3d406898a226
Cr-Commit-Position: refs/heads/master@{#407282}