Issue 2171943002: Alternate approach to updating paint property nodes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2171943002: Alternate approach to updating paint property nodes (Closed)

Created:
4 years, 5 months ago by pdr.

Modified:
4 years, 5 months ago

Reviewers:

CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, slimming-paint-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Alternate approach to updating paint property nodes This patch is a proof of concept of an alternate approach for https://codereview.chromium.org/2144823006. Only one transform node has been implemented. BUG=

Patch Set 1 #

Total comments: 1

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -15 lines)			Patch
M	third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp	View	3 chunks	+29 lines, -12 lines	1 comment	Download
M	third_party/WebKit/Source/platform/graphics/paint/TransformPaintPropertyNode.h	View	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

pdr.

4 years, 5 months ago (2016-07-21 23:14:01 UTC) #1

https://codereview.chromium.org/2171943002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp (right):

https://codereview.chromium.org/2171943002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp:119: if
(!existingTransform) {
Oops, you'll want to do a comparison of the values here too. Something like:
if (!existingTransform || existingTransform->matrix() != matrix ||
existingTransform->origin() != origin)

Expand Messages | Collapse Messages