content/browser/broadcast_channel/broadcast_channel_provider.h - Issue 2171843002: Use array<uint8> rather than string to pass BroadcastChannel messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/broadcast_channel/broadcast_channel_provider.h

Issue 2171843002: Use array<uint8> rather than string to pass BroadcastChannel messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/broadcast_channel/broadcast_channel_provider.cc » ('j') | third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/broadcast_channel/broadcast_channel_provider.h

diff --git a/content/browser/broadcast_channel/broadcast_channel_provider.h b/content/browser/broadcast_channel/broadcast_channel_provider.h

index 7d704ce57142766161a21c481b77f101640df2e9..00db5982cd55e591012a22c38f7d0ef6dd76f841 100644

--- a/content/browser/broadcast_channel/broadcast_channel_provider.h

+++ b/content/browser/broadcast_channel/broadcast_channel_provider.h

@@ -36,7 +36,7 @@ class BroadcastChannelProvider

~BroadcastChannelProvider() override;

void UnregisterConnection(Connection*);

- void ReceivedMessageOnConnection(Connection*, const mojo::String& message);

+ void ReceivedMessageOnConnection(Connection*, mojo::Array<uint8_t> message);

mojo::BindingSet<blink::mojom::BroadcastChannelProvider> bindings_;

std::map<url::Origin, std::multimap<std::string, std::unique_ptr<Connection>>>