Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: content/browser/broadcast_channel/broadcast_channel_provider.cc

Issue 2171843002: Use array<uint8> rather than string to pass BroadcastChannel messages. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/broadcast_channel/broadcast_channel_provider.cc
diff --git a/content/browser/broadcast_channel/broadcast_channel_provider.cc b/content/browser/broadcast_channel/broadcast_channel_provider.cc
index ac34025b229f605b3c52d5e625fcec41e8ea9d2b..c19ffda1d232410618c77ea91bb68009eeeff6fe 100644
--- a/content/browser/broadcast_channel/broadcast_channel_provider.cc
+++ b/content/browser/broadcast_channel/broadcast_channel_provider.cc
@@ -24,9 +24,9 @@ class BroadcastChannelProvider::Connection
blink::mojom::BroadcastChannelClientAssociatedRequest connection,
BroadcastChannelProvider* service);
- void OnMessage(const mojo::String& message) override;
- void MessageToClient(const mojo::String& message) const {
- client_->OnMessage(message);
+ void OnMessage(mojo::Array<uint8_t> message) override;
+ void MessageToClient(mojo::Array<uint8_t> message) const {
+ client_->OnMessage(std::move(message));
}
const url::Origin& origin() const { return origin_; }
const std::string& name() const { return name_; }
@@ -59,8 +59,8 @@ BroadcastChannelProvider::Connection::Connection(
}
void BroadcastChannelProvider::Connection::OnMessage(
- const mojo::String& message) {
- service_->ReceivedMessageOnConnection(this, message);
+ mojo::Array<uint8_t> message) {
+ service_->ReceivedMessageOnConnection(this, std::move(message));
}
BroadcastChannelProvider::BroadcastChannelProvider() {}
@@ -102,13 +102,13 @@ void BroadcastChannelProvider::UnregisterConnection(Connection* c) {
void BroadcastChannelProvider::ReceivedMessageOnConnection(
Connection* c,
- const mojo::String& message) {
+ mojo::Array<uint8_t> message) {
auto& connections = connections_[c->origin()];
for (auto it = connections.lower_bound(c->name()),
end = connections.upper_bound(c->name());
it != end; ++it) {
if (it->second.get() != c)
- it->second->MessageToClient(message);
+ it->second->MessageToClient(message.Clone());
}
}

Powered by Google App Engine
This is Rietveld 408576698