base/files/file_win.cc - Issue 2171833002: Add some words of caution to File::Flush().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_win.cc

Issue 2171833002: Add some words of caution to File::Flush(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PlatformFile.FlushTime histogram. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_win.cc

diff --git a/base/files/file_win.cc b/base/files/file_win.cc

index 83ce88a9a5840f47d82d9f215fed015b32d33a3a..b5bb232a104b878049da3571913b1dd0917e70ea 100644

--- a/base/files/file_win.cc

+++ b/base/files/file_win.cc

@@ -396,9 +396,10 @@ void File::DoInitialize(const FilePath& path, uint32_t flags) {

}

-bool File::DoFlush() {

+bool File::Flush() {

ThreadRestrictions::AssertIOAllowed();

DCHECK(IsValid());

+ SCOPED_FILE_TRACE("Flush");

return ::FlushFileBuffers(file_.Get()) != FALSE;

}