base/files/file_posix.cc - Issue 2171833002: Add some words of caution to File::Flush().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file_posix.cc

Issue 2171833002: Add some words of caution to File::Flush(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PlatformFile.FlushTime histogram. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file_posix.cc

diff --git a/base/files/file_posix.cc b/base/files/file_posix.cc

index 532ae3f0a935fbc111f2b92bb6a41217287f0e50..3d2d54a6632edb7d560c89f81292585663e8e480 100644

--- a/base/files/file_posix.cc

+++ b/base/files/file_posix.cc

@@ -511,9 +511,10 @@ void File::DoInitialize(const FilePath& path, uint32_t flags) {

}

#endif // !defined(OS_NACL)

-bool File::DoFlush() {

+bool File::Flush() {

ThreadRestrictions::AssertIOAllowed();

DCHECK(IsValid());

+ SCOPED_FILE_TRACE("Flush");

#if defined(OS_NACL)

NOTIMPLEMENTED(); // NaCl doesn't implement fsync.