base/files/file.cc - Issue 2171833002: Add some words of caution to File::Flush().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/file.cc

Issue 2171833002: Add some words of caution to File::Flush(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove PlatformFile.FlushTime histogram. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/files/file.cc

diff --git a/base/files/file.cc b/base/files/file.cc

index ab05630062595af1a144d62be815868853fb8c64..1b2224e323eecbb7ba87c323bfa867f4fcfad995 100644

--- a/base/files/file.cc

+++ b/base/files/file.cc

@@ -138,12 +138,4 @@ std::string File::ErrorToString(Error error) {

return "";

}

-bool File::Flush() {

- ElapsedTimer timer;

- SCOPED_FILE_TRACE("Flush");

- bool return_value = DoFlush();

- UMA_HISTOGRAM_TIMES("PlatformFile.FlushTime", timer.Elapsed());

- return return_value;

} // namespace base