Safe browsing subresource filter bubble UI skeleton.

chrome/browser/content_settings/tab_specific_content_settings.h

Index: chrome/browser/content_settings/tab_specific_content_settings.h
diff --git a/chrome/browser/content_settings/tab_specific_content_settings.h b/chrome/browser/content_settings/tab_specific_content_settings.h
index dc20cd102122327bfc9bba8173c947eaabe916de..0c8cdbf545e960dde312fb016eaf1fcb592e246e 100644
--- a/chrome/browser/content_settings/tab_specific_content_settings.h
+++ b/chrome/browser/content_settings/tab_specific_content_settings.h
@@ -37,6 +37,13 @@ namespace net {
 class CookieOptions;
 }
 
+// TODO(msramek): Subresource filter and media currently are storing their state
+// in TabSpecificContentSettings: |microphone_camera_state_| and
+// |subresource_filter_enabled_| without being tight either to a single content

[msramek, 2016/07/27 13:28:26]

nit: tied

[melandory, 2016/07/27 15:05:49]

Done.

+// setting or to any content setting. This state is not ideal, potential
+// solution is to use a map<WebContents*, bool> in the
+// ContentSettingMediaImageModel.
+
 // This class manages state about permissions, content settings, cookies and
 // site data for a specific WebContents. It tracks which content was accessed
 // and which content was blocked. Based on this it provides information about
@@ -188,6 +195,10 @@ class TabSpecificContentSettings
 
   void SetBlockageHasBeenIndicated(ContentSettingsType content_type);
 
+  void SetSubresourceFilteringActivationIndicated();

[msramek, 2016/07/27 13:28:27]

Why the renaming to "FilteringActivation"? Since the filtering really blocks
content (just like the oldest content settings do), I would prefer the original
naming with "blocked", "blockage", etc.

[melandory, 2016/07/27 15:05:48]

Done.

+
+  bool IsSubresourceFilteringActivationIndicated() const;
+
   // Returns whether a particular kind of content has been allowed. Currently
   // only tracks cookies.
   bool IsContentAllowed(ContentSettingsType content_type) const;
@@ -240,6 +251,12 @@ class TabSpecificContentSettings
     return midi_usages_state_;
   }
 
+  bool IsSubresourceBlocked() const { return subresource_filter_enabled_; }

[msramek, 2016/07/27 13:28:26]

AFAIU, in general a method can be inlined in .cc file only if it's exactly of
the form:

lower_case_identifier() { return lower_case_identifier_; }

But in any case, I'd like to have these defined in the .cc file because the
standard methods for content settings are also defined there.

Basically, it should be clear that subresource filter behaves the same way as
content settings do here, it's just not a content setting. So please follow this
ordering and naming conventions.

bool SetPopupsBlocked();
bool SetDownloadsBlocked();
bool SetSubresourceBlocked();   <----

bool IsContentBlocked();
bool IsSubresourceBlocked();    <----

bool IsBlockageIndicated();
bool IsSubresourceBlockageIndicated();    <----

bool SetBlockageHasBeenIndicated();
bool SetSubresourceBlockageIndicated();   <----

[melandory, 2016/07/27 15:05:49]

Done
Done
Done
Done

+
+  void SetSubresourceFilterEnabledd(bool enabled) {

[msramek, 2016/07/27 13:28:27]

typo: Enabled (single "d")

[melandory, 2016/07/27 15:05:48]

Done.

+    subresource_filter_enabled_ = enabled;
+  }
+
   // Call to indicate that there is a protocol handler pending user approval.
   void set_pending_protocol_handler(const ProtocolHandler& handler) {
     pending_protocol_handler_ = handler;
@@ -467,6 +484,10 @@ class TabSpecificContentSettings
   std::string media_stream_requested_audio_device_;
   std::string media_stream_requested_video_device_;
 
+  // Manages information about Subresource filtering activation.
+  bool subresource_filter_enabled_;
+  bool subresource_filter_blockage_indicated_;
+
   // Observer to watch for content settings changed.
   ScopedObserver<HostContentSettingsMap, content_settings::Observer> observer_;