Safe browsing subresource filter bubble UI skeleton.

chrome/browser/content_settings/tab_specific_content_settings.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 #define CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 19 matching lines @@
 class HostContentSettingsMap;
 
 namespace content {
 class RenderViewHost;
 }
 
 namespace net {
 class CookieOptions;
 }
 
+// TODO(msramek): Subresource filter and media currently are storing their state
+// in TabSpecificContentSettings: |microphone_camera_state_| and
+// |subresource_filter_enabled_| without being tight either to a single content

[msramek, 2016/07/27 13:28:26]

nit: tied

[melandory, 2016/07/27 15:05:49]

Done.

+// setting or to any content setting. This state is not ideal, potential
+// solution is to use a map<WebContents*, bool> in the
+// ContentSettingMediaImageModel.
+
 // This class manages state about permissions, content settings, cookies and
 // site data for a specific WebContents. It tracks which content was accessed
 // and which content was blocked. Based on this it provides information about
 // which types of content were accessed and blocked.
 class TabSpecificContentSettings
     : public content::WebContentsObserver,
       public content_settings::Observer,
       public content::WebContentsUserData<TabSpecificContentSettings> {
  public:
   // Fields describing the current mic/camera state. If a page has attempted to
@@ skipping 131 matching lines @@
 
   // Returns whether a particular kind of content has been blocked for this
   // page.
   bool IsContentBlocked(ContentSettingsType content_type) const;
 
   // Returns true if content blockage was indicated to the user.
   bool IsBlockageIndicated(ContentSettingsType content_type) const;
 
   void SetBlockageHasBeenIndicated(ContentSettingsType content_type);
 
+  void SetSubresourceFilteringActivationIndicated();

[msramek, 2016/07/27 13:28:27]

Why the renaming to "FilteringActivation"? Since the filtering really blocks
content (just like the oldest content settings do), I would prefer the original
naming with "blocked", "blockage", etc.

[melandory, 2016/07/27 15:05:48]

Done.

+
+  bool IsSubresourceFilteringActivationIndicated() const;
+
   // Returns whether a particular kind of content has been allowed. Currently
   // only tracks cookies.
   bool IsContentAllowed(ContentSettingsType content_type) const;
 
   // Returns the names of plugins that have been blocked for this tab.
   const std::vector<base::string16>& blocked_plugin_names() const {
     return blocked_plugin_names_;
   }
 
   const GURL& media_stream_access_origin() const {
@@ skipping 32 matching lines @@
   const ContentSettingsUsagesState& geolocation_usages_state() const {
     return geolocation_usages_state_;
   }
 
   // Returns the ContentSettingsUsageState that controls the MIDI usage on
   // this page.
   const ContentSettingsUsagesState& midi_usages_state() const {
     return midi_usages_state_;
   }
 
+  bool IsSubresourceBlocked() const { return subresource_filter_enabled_; }

[msramek, 2016/07/27 13:28:26]

AFAIU, in general a method can be inlined in .cc file only if it's exactly of
the form:

lower_case_identifier() { return lower_case_identifier_; }

But in any case, I'd like to have these defined in the .cc file because the
standard methods for content settings are also defined there.

Basically, it should be clear that subresource filter behaves the same way as
content settings do here, it's just not a content setting. So please follow this
ordering and naming conventions.

bool SetPopupsBlocked();
bool SetDownloadsBlocked();
bool SetSubresourceBlocked();   <----

bool IsContentBlocked();
bool IsSubresourceBlocked();    <----

bool IsBlockageIndicated();
bool IsSubresourceBlockageIndicated();    <----

bool SetBlockageHasBeenIndicated();
bool SetSubresourceBlockageIndicated();   <----

[melandory, 2016/07/27 15:05:49]

Done
Done
Done
Done

+
+  void SetSubresourceFilterEnabledd(bool enabled) {

[msramek, 2016/07/27 13:28:27]

typo: Enabled (single "d")

[melandory, 2016/07/27 15:05:48]

Done.

+    subresource_filter_enabled_ = enabled;
+  }
+
   // Call to indicate that there is a protocol handler pending user approval.
   void set_pending_protocol_handler(const ProtocolHandler& handler) {
     pending_protocol_handler_ = handler;
   }
 
   const ProtocolHandler& pending_protocol_handler() const {
     return pending_protocol_handler_;
   }
 
   void ClearPendingProtocolHandler() {
@@ skipping 207 matching lines @@
   MicrophoneCameraState microphone_camera_state_;
   // The selected devices at the last media stream request.
   std::string media_stream_selected_audio_device_;
   std::string media_stream_selected_video_device_;
 
   // The devices to be displayed in the media bubble when the media stream
   // request is requesting certain specific devices.
   std::string media_stream_requested_audio_device_;
   std::string media_stream_requested_video_device_;
 
+  // Manages information about Subresource filtering activation.
+  bool subresource_filter_enabled_;
+  bool subresource_filter_blockage_indicated_;
+
   // Observer to watch for content settings changed.
   ScopedObserver<HostContentSettingsMap, content_settings::Observer> observer_;
 
   DISALLOW_COPY_AND_ASSIGN(TabSpecificContentSettings);
 };
 
 #endif  // CHROME_BROWSER_CONTENT_SETTINGS_TAB_SPECIFIC_CONTENT_SETTINGS_H_