Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 217163004: Remove the fullScreenEnabled setting (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 9 months ago
CC:
blink-reviews, jamesr, sof, gasubic, eae+blinkwatch, fs, eric.carlson_apple.com, abarth-chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, adamk+blink_chromium.org, rwlbuis, vcarbune.chromium, Inactive
Visibility:
Public.

Description

Remove the fullScreenEnabled setting Chromium always calls setFullScreenEnabled(true). BUG=344002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -58 lines) Patch
M LayoutTests/media/video-controls-fullscreen.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/video-controls-fullscreen.js View 2 chunks +7 lines, -16 lines 0 comments Download
D LayoutTests/media/video-controls-fullscreen-disabled.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/media/video-controls-fullscreen-disabled-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/media/video-controls-fullscreen-with-controller.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/FullscreenElementStack.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebSettings.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
philipj_slow
PTAL. I didn't realize the setting was always true (despite initial=false) and have wasted time ...
6 years, 9 months ago (2014-03-28 17:56:43 UTC) #1
philipj_slow
Here are the two patches that will finish the job: https://codereview.chromium.org/216233008/ https://codereview.chromium.org/217293002/
6 years, 9 months ago (2014-03-28 18:07:26 UTC) #2
eseidel
lgtm
6 years, 9 months ago (2014-03-28 18:30:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/217163004/1
6 years, 9 months ago (2014-03-28 18:31:04 UTC) #4
commit-bot: I haz the power
Change committed as 170351
6 years, 9 months ago (2014-03-28 19:09:58 UTC) #5
abarth-chromium
http://www.gbeye.com/images/site_images/gbeyebtob/lightbox/originals/0004/0534/FP3134-DOCTOR-WHO-daleks-exterminate.jpg/1385371559/FP3134-DOCTOR-WHO-daleks-exterminate.jpg
6 years, 9 months ago (2014-03-28 22:36:17 UTC) #6
philipj_slow
6 years, 9 months ago (2014-03-29 04:31:00 UTC) #7
Message was sent while issue was closed.
abarth gets the reference :)

Powered by Google App Engine
This is Rietveld 408576698